Problem/Motivation

The a.rel="home" attribute, which is used on multiple places in Drupal core templates, is wrong because it does not exist in specification, as explained in https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel.

This problem was pointed by @andy_blum in Slack discussion about some site logo link accessibility problems we are trying to figure for our contrib base theme.

Proposed resolution

Remove rel="home" from Drupal core.

CommentFileSizeAuthor
#2 remove-rel-home-3347449-2.patch10.23 KBpivica

Issue fork drupal-3347449

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Status: Active » Needs review
StatusFileSize
new remove-rel-home-3347449-2.patch10.23 KB

Here is a patch.

Status: Needs review » Needs work

The last submitted patch, 2: remove-rel-home-3347449-2.patch, failed testing. View results

Ranjit1032002 made their first commit to this issue’s fork.

Ranjit1032002 opened merge request !3635

ranjit1032002’s picture

ranjit1032002
Primary language English
Location India
commented
Status: Needs work » Needs review

Created MR!3635 for the issue metioned , please review.

Thank you

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Issue tags: +Needs change record, +Needs subsystem maintainer review

This is a potentially BC-breaking change as sites may be using attribute selectors to target this link for CSS, even though the rel attribute isn't technically valid.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.