Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
SessionConfiguration::getCookieDomain() retrieves the cookie domain value that should be used. It does some basic sanity-checking on the value and returns NULL if it is not a valid domain attribute for the set-cookie header. However, this is not properly documented and also the sanity-check appears to have an IPv4 bias, so adding to that inline documentation to explain why it is OK as-is.
Steps to reproduce
This is a docs-only bug.
Proposed resolution
Clarify docs.
Remaining tasks
Review.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Screenshot 2023-03-12 at 10.22.13 PM.png | 562.49 KB | rohan-sinha |
Issue fork drupal-3347443
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
bradjones1Comment #4
rohan-sinha commentedReviewed the MR, Doc value is corrected, can be merged, thanks.
Comment #5
longwaveCommitted and pushed 088568e546 to 10.1.x and 6d74e7951e to 10.0.x and 1bb008826c to 9.5.x. Thanks!