Closed (fixed)
Project:
Drupal core
Version:
10.3.x-dev
Component:
action.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Feb 2023 at 09:35 UTC
Updated:
30 Jun 2025 at 05:11 UTC
Jump to comment: Most recent
Comments
Comment #2
quietone commentedThere are no migrations to move, this was already done in #3067299: Move actions migrations and tests to system module.
Comment #3
quietone commentedI did not find action module in any profile.
Comment #4
andypostFiled child issue #3344683: Unreserve or create "action" module in contrib
Comment #5
andypostLooks that's the only task from summary left
Comment #6
andypostThere's only one usage in
drupal-9.4.0.filled.standard.php.gz(core.extension) and later in routingComment #7
dwwWhoops, a bit late to the game. Wish I saw all this in time to have posted this to #3266458: [Policy] Deprecate Action (UI) module in D10 and move to contrib in D11, but that's already done and decided...
While I mostly agree that the "Actions UI" module is confusing and not terribly helpful on its own, #2797583: Dynamically provide action plugins for every moderation state change is categorized as a "Major feature", followed by 152 (which is very high for most core issues). Perhaps that issue can be changed so that you don't have to enable the Action UI to create individual actions for the content_moderation transitions you want, and it would instead dynamically provide actions for everything automatically. But that'd introduce its own UI problems, since then everywhere you get a list of actions, you might have dozens of new actions you have to hide that don't make sense, etc. It's clunky, but having to manually create the actions you actually need (instead of getting everything automatically) is kinda helpful.
Anyway, would love to hear thoughts on how to handle (much needed) functionality like that issue, if we have no more Actions UI in core.
Thanks/sorry!
-Derek
Comment #8
andypostAs I see we have no contribution to actions at all because of this incomplete transition to contrib
To unblock we should deprecate it or unblock issues
Comment #10
quietone commentedComment #11
quietone commentedComment #12
quietone commentedComment #13
quietone commentedFound tests that are not in the action module that are installing the action.
Comment #14
andypostcurious about tests as node/comment actions require actions UI to be configured
which means we can not do functional testing without it
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/node/...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/comme...
Comment #15
quietone commentedCan you point to a specific test? My searching does not find any other test that installs the Action module. The comment tests look like they use actions but not the UI provided by the Action module.
Comment #16
andypostAdded links to #14 - both plugins require ui to configure keywords
Comment #17
catchCommentActionsTest directly updates the plugin configuration to test the keywords functionality, so I think the plugin and tests will continue to work if we move action module to contrib.
However, I'm not sure those two plugins make sense without a UI, so maybe we should also consider an issue to move them into the actions_ui module?
Comment #18
andypostNot sure it makes sense to deprecate them, because there's goto,message,email actions in core https://git.drupalcode.org/project/drupal/-/tree/11.x/core/lib/Drupal/Co...
Comment #19
wim leersJust ran into obscure Action-related edge cases over at #3361534-70: KernelTestBase::$strictConfigSchema = TRUE and BrowserTestBase::$strictConfigSchema = TRUE do not actually strictly validate. Glad to see this happening!
Comment #20
wim leersOh and per #3266458-11: [Policy] Deprecate Action (UI) module in D10 and move to contrib in D11, I think this issue is a bit misleading — is this tweak accurate? 😅
Comment #21
quietone commentedComment #22
catchComment #23
andypostLast blocker is RTBC #3413949: Move some Action plugins to Action module
Now it needs infra team to create project and then I can split 1.x branch in #3344683: Unreserve or create "action" module in contrib
Comment #24
andypostComment #25
andypostNow only deprecation of module is lest #3369912: Final steps to deprecate Actions UI (action) module
I'm going to append split in contrib after #3413949: Move some Action plugins to Action module
Btw the cleanup landed with 2 follow-ups
- #3427413: Stop using action in user module in role entity hooks
- #3427549: [PP-1] Move configurable user actions to the actions module
Comment #26
andypostDocs updated https://www.drupal.org/node/3223395#s-action
Comment #27
andypostNew release https://www.drupal.org/project/action/releases/0.1.0
Comment #28
catchThe project page could use an update: https://www.drupal.org/project/action, it's currently using the template.
Comment #29
andypostI did update of project page, looks we can mark it fixed
Comment #30
catchYep ready to go now I think!
Comment #31
andypostFiled follow-up #3437589: Move permission, jsonapi and rest tests out of the action module
Comment #33
quietone commented