[meta] Tasks to deprecate Actions UI module [#3343369]

Problem/Motivation

Track the steps needed to remove extension Action from core to contrib. See Remove a core module and move it to a contributed project of the deprecation policy.

The removal of extension Action was approved in #3266458: [Policy] Deprecate Action (UI) module in D10 and move to contrib in D11.

Remaining tasks

Begin finding someone to maintain the contrib version of the extension. (andypost)
Move integrations implemented by other modules to the extension.
Create child issues or child meta issues, as needed, to address the following points. Not all points will apply to all extensions.
- Move non-migration tests to the extension. #3369914: Move non-migrations tests to Actions module
- Remove install of Action from migration tests. #3369916: Remove install of action module from migration tests
- Removing references to the extension from database dumps. #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x
- Update Update path tests. See Writing Automated Update Tests for Drupal 8 (or later) for details.
#3413949: Move some Action plugins to Action module
Do a thorough search of core for any remaining references to the extension. If references are found, outside of the extension, then create issues to remove the references.
Create the contrib project with a stable release. #3344683: Unreserve or create "action" module in contrib
Deprecate the core extension. Use the Issue Summary template or core extension deprecation. #3369912: Final steps to deprecate Actions UI (action) module
Release 1.0 in contrib and proceed to #3427413: Stop using action in user module in role entity hooks

Completed tasks

Fix migration test. #3343598: Remove action module from MigrationPluginListTest
Move Help Topics to the extension. #3343600: Move help topics to actions module
Remove templates from the extension’s markup.
- Remove templates from themes that are staying in core, leave them in deprecated themes
- Keep skipping the template in the stable copies test.
For a module, handle migrations, if the module has migrations. The migrations have already been moved #3067299: Move actions migrations and tests to system module.

Comments

Comment #1

21 February 2023 at 09:35

quietone created an issue. See original summary.

Comment #2

quietone commented 22 February 2023 at 04:51

Issue summary:

View changes

There are no migrations to move, this was already done in #3067299: Move actions migrations and tests to system module.

Comment #3

quietone commented 22 February 2023 at 05:42

Issue summary:

View changes

I did not find action module in any profile.

Comment #4

andypost

he/him

Russian

commented 27 February 2023 at 12:30

Filed child issue #3344683: Unreserve or create "action" module in contrib

Comment #5

andypost

he/him

Russian

commented 18 April 2023 at 20:59

Removing references to the extension from database dumps.

Looks that's the only task from summary left

Comment #6

andypost

he/him

Russian

commented 18 April 2023 at 21:09

There's only one usage in drupal-9.4.0.filled.standard.php.gz (core.extension) and later in routing

'data' => 'a:3:{s:6:"module";a:60:{s:6:"action";i:0;s:14:"automated_cron";i:0;s:3:"ban";i:0;s:10:"basic_auth";i:0;s:5:"block";i:0;s:13:"block_content";i:0;s:4:"book";i:0;s:10:"breakpoint";i:0;s:9:"ckeditor5";i:0;s:7:"comment";i:0;s:6:"config";i:0;s:18:"config_translation";i:0;s:7:"contact";i:0;s:19:"content_translation";i:0;s:10:"contextual";i:0;s:8:"datetime";i:0;s:5:"dblog";i:0;s:6:"editor";i:0;s:5:"field";i:0;s:8:"field_ui";i:0;s:4:"file";i:0;s:6:"filter";i:0;s:4:"help";i:0;s:7:"history";i:0;s:5:"image";i:0;s:8:"language";i:0;s:4:"link";i:0;s:6:"locale";i:0;s:7:"menu_ui";i:0;s:7:"migrate";i:0;s:14:"migrate_drupal";i:0;s:5:"mysql";i:0;s:4:"node";i:0;s:7:"options";i:0;s:10:"page_cache";i:0;s:4:"path";i:0;s:10:"path_alias";i:0;s:5:"pgsql";i:0;s:16:"responsive_image";i:0;s:4:"rest";i:0;s:6:"search";i:0;s:13:"serialization";i:0;s:8:"shortcut";i:0;s:6:"sqlite";i:0;s:10:"statistics";i:0;s:6:"syslog";i:0;s:6:"system";i:0;s:8:"taxonomy";i:0;s:9:"telephone";i:0;s:4:"text";i:0;s:7:"toolbar";i:0;s:4:"tour";i:0;s:7:"tracker";i:0;s:6:"update";i:0;s:4:"user";i:0;s:8:"views_ui";i:0;s:5:"forum";i:1;s:17:"menu_link_content";i:1;s:5:"views";i:10;s:8:"standard";i:1000;}s:5:"theme";a:3:{s:5:"stark";i:0;s:5:"claro";i:0;s:7:"olivero";i:0;}s:7:"profile";s:8:"standard";}',

Comment #7

dww

we/he/they

commented 20 April 2023 at 04:53

Whoops, a bit late to the game. Wish I saw all this in time to have posted this to #3266458: [Policy] Deprecate Action (UI) module in D10 and move to contrib in D11, but that's already done and decided...

While I mostly agree that the "Actions UI" module is confusing and not terribly helpful on its own, #2797583: Dynamically provide action plugins for every moderation state change is categorized as a "Major feature", followed by 152 (which is very high for most core issues). Perhaps that issue can be changed so that you don't have to enable the Action UI to create individual actions for the content_moderation transitions you want, and it would instead dynamically provide actions for everything automatically. But that'd introduce its own UI problems, since then everywhere you get a list of actions, you might have dozens of new actions you have to hide that don't make sense, etc. It's clunky, but having to manually create the actions you actually need (instead of getting everything automatically) is kinda helpful.

Anyway, would love to hear thoughts on how to handle (much needed) functionality like that issue, if we have no more Actions UI in core.

Thanks/sorry!
-Derek

Comment #8

andypost

he/him

Russian

commented 21 April 2023 at 13:15

As I see we have no contribution to actions at all because of this incomplete transition to contrib

To unblock we should deprecate it or unblock issues

Comment #9

21 April 2023 at 13:15

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #10

quietone commented 25 June 2023 at 02:41

Issue summary:

View changes

Comment #11

quietone commented 25 June 2023 at 02:43

Issue summary:

View changes

Comment #12

quietone commented 25 June 2023 at 02:43

Issue summary:

View changes

Comment #13

quietone commented 25 June 2023 at 04:42

Issue summary:

View changes

Found tests that are not in the action module that are installing the action.

Comment #14

andypost

he/him

Russian

commented 25 June 2023 at 04:47

curious about tests as node/comment actions require actions UI to be configured

which means we can not do functional testing without it

- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/node/...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/comme...

Comment #15

quietone commented 25 June 2023 at 04:59

Can you point to a specific test? My searching does not find any other test that installs the Action module. The comment tests look like they use actions but not the UI provided by the Action module.

Comment #16

andypost

he/him

Russian

commented 25 June 2023 at 05:02

Added links to #14 - both plugins require ui to configure keywords

Comment #17

catch

he/him

English

commented 26 June 2023 at 08:49

CommentActionsTest directly updates the plugin configuration to test the keywords functionality, so I think the plugin and tests will continue to work if we move action module to contrib.

However, I'm not sure those two plugins make sense without a UI, so maybe we should also consider an issue to move them into the actions_ui module?

Comment #18

andypost

he/him

Russian

commented 26 June 2023 at 11:16

Not sure it makes sense to deprecate them, because there's goto,message,email actions in core https://git.drupalcode.org/project/drupal/-/tree/11.x/core/lib/Drupal/Co...

Comment #19

wim leers

Ghent 🇧🇪🇪🇺

commented 25 July 2023 at 14:45

Just ran into obscure Action-related edge cases over at #3361534-70: KernelTestBase::$strictConfigSchema = TRUE and BrowserTestBase::$strictConfigSchema = TRUE do not actually strictly validate. Glad to see this happening!

Comment #20

wim leers

Ghent 🇧🇪🇪🇺

commented 25 July 2023 at 14:46

Title:

[meta] Tasks to deprecate Action module

» [meta] Tasks to deprecate Actions UI module

Oh and per #3266458-11: [Policy] Deprecate Action (UI) module in D10 and move to contrib in D11, I think this issue is a bit misleading — is this tweak accurate? 😅

Comment #21

quietone commented 11 January 2024 at 07:41

Issue summary:

View changes

Comment #22

catch

he/him

English

commented 14 January 2024 at 11:32

Comment #23

andypost

he/him

Russian

commented 1 March 2024 at 22:51

Issue summary:

View changes

Last blocker is RTBC #3413949: Move some Action plugins to Action module

Now it needs infra team to create project and then I can split 1.x branch in #3344683: Unreserve or create "action" module in contrib

Comment #24

andypost

he/him

Russian

commented 1 March 2024 at 22:55

Issue summary:

View changes

Comment #25

andypost

he/him

Russian

commented 13 March 2024 at 23:05

Issue summary:	View changes
Related issues:		+#3427413: Stop using action in user module in role entity hooks, +#3427549: [PP-1] Move configurable user actions to the actions module

Now only deprecation of module is lest #3369912: Final steps to deprecate Actions UI (action) module

I'm going to append split in contrib after #3413949: Move some Action plugins to Action module

Btw the cleanup landed with 2 follow-ups
- #3427413: Stop using action in user module in role entity hooks
- #3427549: [PP-1] Move configurable user actions to the actions module