Problem/Motivation
Remove Statistics from core.
Steps to reproduce
Proposed resolution
Remove usage in \Drupal\Tests\migrate_drupal\Kernel\Plugin\migrate\DestinationCategoryTest
Possibly merge this #3416612: [11.x] Remove statistics from htaccess
Remaining tasks
- The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-Book. (For example, the CR for removing HAL)
- Tag this issue 'Needs release note.'
Remove the extension ;-).Remove references fromcore/phpstan-baseline.neon.Remove any spelling words specific to the extension from the dictionaryCheck for references in @todo.-
Handle migration tests.In all the functional tests in migrate_drupal_ui make sure that 'statistics' is not installed. Statistics should also be removed from the methods getAvailablePaths() and moved to getMissingPaths() in the tests using those methods.
Update Wiki page with changes to htaccess
User interface changes
API changes
Data model changes
Release notes snippet
The default <code>.htaccess file has changed to remove support for the statistics module, which has been moved to a contributed module (and now provides its own htaccess protection). Sites should ensure the redundant .htaccess rule is removed from their own copy of the file.
Issue fork drupal-3341092
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3341092-11.x-remove-statistics
changes, plain diff MR !6782
Comments
Comment #2
quietone commentedComment #3
gábor hojtsyUpdating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...
Comment #4
quietone commentedComment #5
quietone commentedI found another usage in a test, \Drupal\Tests\migrate_drupal\Kernel\Plugin\migrate\DestinationCategoryTest. When the color module was removed from core this test was changed, it was not done as part of the deprecation of the module. Therefore I am adding it here.
Comment #7
quietone commentedComment #8
quietone commentedThe remaining failing tests are update tests.
Comment #9
quietone commentedComment #10
quietone commentedI've been searching core for references to the statistics module. I found references to in content_translation for migrations. That needs investigation.
Comment #11
quietone commentedWhat was found about content_translation was resolved in #3424009: Move statistics_node_translation_counter to Statistics module
Comment #12
quietone commentedComment #13
quietone commentedThe failing tests are Update tests as expected.
Comment #14
andypostComment #15
quietone commentedAlthough, still needs a release note about .htaccess
Comment #16
catchAdded a release note.
Comment #17
catchLooks great, only a handful of lines outside of statistics module itself.
Comment #18
alexpottNeeds to be rebased or have 11.x merged in.
Comment #19
catchRebased.
Comment #20
alexpottCommitted aa1e792 and pushed to 11.x. Thanks!