Problem/Motivation

Remove Statistics from core.

Steps to reproduce

Proposed resolution

Remove usage in \Drupal\Tests\migrate_drupal\Kernel\Plugin\migrate\DestinationCategoryTest
Possibly merge this #3416612: [11.x] Remove statistics from htaccess

Remaining tasks

  • The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-Book. (For example, the CR for removing HAL)
  • Tag this issue 'Needs release note.'
  • Remove the extension ;-).
  • Remove references from core/phpstan-baseline.neon.
  • Remove any spelling words specific to the extension from the dictionary
  • Check for references in @todo.
  • Handle migration tests.
    • In all the functional tests in migrate_drupal_ui make sure that 'statistics' is not installed. Statistics should also be removed from the methods getAvailablePaths() and moved to getMissingPaths() in the tests using those methods.

Update Wiki page with changes to htaccess

User interface changes

API changes

Data model changes

Release notes snippet

The default <code>.htaccess file has changed to remove support for the statistics module, which has been moved to a contributed module (and now provides its own htaccess protection). Sites should ensure the redundant .htaccess rule is removed from their own copy of the file.

Issue fork drupal-3341092

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

quietone’s picture

Status: Active » Postponed
gábor hojtsy’s picture

Title: Remove Statistics from core » [11.x] Remove Statistics from core
Version: 11.0.x-dev » 11.x-dev
Issue tags: +Major version only

Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...

quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes

I found another usage in a test, \Drupal\Tests\migrate_drupal\Kernel\Plugin\migrate\DestinationCategoryTest. When the color module was removed from core this test was changed, it was not done as part of the deprecation of the module. Therefore I am adding it here.

quietone’s picture

Title: [11.x] Remove Statistics from core » Remove Statistics from core
Issue summary: View changes
quietone’s picture

The remaining failing tests are update tests.

quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes

I've been searching core for references to the statistics module. I found references to in content_translation for migrations. That needs investigation.

quietone’s picture

What was found about content_translation was resolved in #3424009: Move statistics_node_translation_counter to Statistics module

quietone’s picture

Issue summary: View changes
quietone’s picture

The failing tests are Update tests as expected.

andypost’s picture

Status: Postponed » Needs work
quietone’s picture

Status: Needs work » Needs review

Although, still needs a release note about .htaccess

catch’s picture

Issue summary: View changes
Issue tags: -Needs release note

Added a release note.

catch’s picture

Status: Needs review » Reviewed & tested by the community

Looks great, only a handful of lines outside of statistics module itself.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs to be rebased or have 11.x merged in.

catch’s picture

Status: Needs work » Reviewed & tested by the community

Rebased.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed aa1e792 and pushed to 11.x. Thanks!

  • alexpott committed aa1e7921 on 11.x
    Issue #3341092 by quietone, catch: Remove Statistics from core
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.