The string "required" is repeated five times below the admin/modules table (matching up with the number of required modules). This shouldn't be there.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | forms3.patch | 1008 bytes | chx |
| #2 | require_suffix.patch | 715 bytes | jakeg |
The string "required" is repeated five times below the admin/modules table (matching up with the number of required modules). This shouldn't be there.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | forms3.patch | 1008 bytes | chx |
| #2 | require_suffix.patch | 715 bytes | jakeg |
Comments
Comment #1
jakeg commentedCould it be to do with the 'suffix' not being part of the 'content' and hence not counted as actual output in the if statement?
line 577+ in form.inc...
could become
... works, but is this the best way/what we're trying to do?
Comment #2
jakeg commentedOkay, my first ever go at making a patch. here it is. let me know if i've done anything wrong.
Comment #3
chx commentedThe problem is that when the final
form_renderis called, we take care of not rendering the elements again but the prefix and suffix is not checked for this. See the simple fix in the patch.Also included is a minor fix to make code more elegant.
Comment #4
chx commentedComment #5
(not verified) commented