Problem/Motivation
PHPStan baseline is currently skipping multiple Call to an undefined method errors.
Proposed resolution
Fix Updater errors, clean up the baseline.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3317652-5.patch | 1.36 KB | mondrake |
PHPStan baseline is currently skipping multiple Call to an undefined method errors.
Fix Updater errors, clean up the baseline.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3317652-5.patch | 1.36 KB | mondrake |
Comments
Comment #2
mondrakeComment #3
longwaveI am sure in this case this could just be abstract? Updaters are only used by core, there are only Module and Theme implementations, and I don't see a use case outside of that.
Comment #4
mondrakeThanks @longwave, NW
Comment #5
mondrakeComment #6
longwaveThanks, I think this is fine even if it's technically an API change - all this Updater code should be considered internal as far as I can see.
Comment #7
alexpottCommitted d96c99b and pushed to 10.1.x. Thanks!
Committed 104a255 and pushed to 10.0.x. Thanks!
I debated whether we should have a CR for this but I don't think so. The only stuff I can find in contrib is from clones of core... see https://git.drupalcode.org/search?group_id=2&page=3&repository_ref=&scop...
I think we should file a follow-up for the abstract class to implement \Drupal\Core\Updater\UpdaterInterface and then fix the docs in the abstract to use @inheritdoc.
Comment #10
mondrakeFiled #3318850: Make Updater implement UpdaterInterface.