In #3231950: Split Database tests in 'core' ones and 'driver specific' ones, most database-specific kernel tests were moved to the driver modules.
However, there are still some tests in the base Database kernel tests where checks are executed conditionally on the driver()/databaseType() results:
Drupal\KernelTests\KernelTestBaseTest
Drupal\Tests\system\Kernel\Scripts\DbCommandBaseTest
Drupal\Tests\system\Kernel\Scripts\DbDumpCommandTest
Drupal\KernelTests\Core\Database\SchemaTest
Drupal\KernelTests\Core\Command\DbDumpTest
Extrapolate those tests into appropriate module kernel test classes extending DriverSpecificDatabaseTestBase.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !2880
Comments
Comment #3
mondrakeComment #4
daffie commentedAll test changes look good to me.
The database driver specific testing has been moved to the specific database drivers module.
For me is it RTBC.
@mondrake: Thank you for this issue and the MR.
Comment #6
catchI noticed some nits in comments etc., but they're moved one-to-one from one file to another (and only once, it's not that we're copying the same mistake to additional places), so rather than derail this I'm holding my tongue. Everything else looks good and nice to clean this up.
Committed/pushed to 10.1.x and 10.0.x, thanks!
Comment #7
mondrake@catch if you can please add comments about the nits to the MR - I think it would be good to cleanup in a follow up. These tests are pretty old and would benefit some care.