Meeting will happen in #d10readiness on drupal.slack.com.
| andypost |
Andy, contributor |
| hestenet (he/him) |
Tim from the DA :wave::skin-tone-3: |
| VinmayiSwamy |
Vinmayi, contributor from India :wave: |
| longwave |
Dave, core contributor, UK |
| Björn Brala (bbrala) |
Hi! Walking and posting a little. :sweat_smile: |
| quietone |
Hi |
| Kristen Pol (she/her) |
Kristen, California, catching up |
| Vighnesh Sadagopal |
Vighneshh, India :wave: |
| Tinto |
Hello from Amsterdam, NL :blob_wave: |
| Gábor Hojtsy (he/him) |
Raised by @hestenet (he/him) |
| Gábor Hojtsy (he/him) |
Historically this has resulted in a number of new tests failures needing minor fixes. The current version is fairly out of date, but we also don’t want to disrupt beta/rc process.(edited) |
| andypost |
https://www.drupal.org/project/drupalci_environments/issues/3306450 |
| andypost |
Moreover tests of last PHP 8.2 patch shos random failureshttps://www.drupal.org/pift-ci-job/2487663 the only green run (edited) |
| longwave |
it likely has to be coordinated with an upgrade of the JavaScript chromedriver package that we use - but this also has an implication of what to do about existing branches/tags that still have the old chromedriver |
| longwave |
I do wonder if we should ship a Dockerfile with core that builds the chromedriver container at CI runtime and then core developers can upgrade it in lockstep and we can have different versions for different branches |
| longwave |
Happy to discuss this with anyone interested in making this work! |
| longwave |
@hestenet (he/him) do you know if this could be as simple as adding a docker build command to drupalci.yml and tagging the image appropriately? Or is the chromedriver container run separately/elsewhere? (edited) |
| longwave |
or is this something we should look at in gitlab CI instead? |
| hestenet (he/him) |
Honestly we should probably plan to do this in GitLab CI - although GitLab CI for core specifically may still take a while because of all the care we want to take with core dev processes. |
| hestenet (he/him) |
It might work with a docker build command in drupalci.yml, in fact.. |
| longwave |
Might have a play with a docker build step and see what happens :+1: |
| berdir |
I was able to use that container in a ddev project |
| berdir |
and I've updated the docs a bit for more recent versions: https://www.drupal.org/docs/automated-testing/phpunit-in-drupal/running-... |
| longwave |
yeah I use it for running core JS tests locally in ddev, works well for that |
| andypost |
having ability to configure chromium image will allow testing on firefox |
| andypost |
Used to run tests using zenika/alpine-chrome:with-chromedriver 102.0.5005.158 and can't reproduce failures from CI |
| xjm |
I would say "as soon as possible" -- beta is a good time to sort this out. |
| hestenet (he/him) |
Okay! Can try to prioritize quickly then - thank you |
| hestenet (he/him) |
Okay! Can try to prioritize quickly then - thank you |
| xjm |
@hestenet (he/him) Like it's not on fire, but I also would not wait a month or for any particular core milestone that does not already exist |
| hestenet (he/him) |
Latest chromedriver image pushed: https://hub.docker.com/repository/docker/drupalci/chromedriver |
| andypost |
Thanks a lot, looks everything works |
| xjm |
No significant change in fail rates so far |
| Gábor Hojtsy (he/him) |
Raised by @andypost |
| Gábor Hojtsy (he/him) |
see[#1120020] |
| hestenet (he/him) |
@andypost could you make an issue in: https://www.drupal.org/project/drupalci_environments/ - I think this is something I can figure out. |
| andypost |
Maybe it could be do e in context of[#3283449] |
| andypost |
I recall @xjm also was looking for sqlite issues |
| hestenet (he/him) |
That issue is fine I think.. |
| hestenet (he/him) |
Yeah - there are 2 core sqlite issues and then whatever we can figure out from an infra point of view as well. |
| andypost |
Yes, the second is about variable limit I bet |
| andypost |
But general issue is[#3273626] |
| hestenet (he/him) |
And this one, yah:#1120020: SQLite database locking errors cause fatal errors |
| hestenet (he/him) |
Anyway - I'll see what I can do about php 8.2 + sqlite env.. |
| hestenet (he/him) |
Er - title of this thread should be 'SQLite + PHP 8,2' |
| hestenet (he/him) |
PHP 8.2 and Sqlite 3.27 env added - and an initial test queued @andypost: https://www.drupal.org/pift-ci-job/2490356 |
| andypost |
Thank you, queued too https://www.drupal.org/pift-ci-job/2490357 |
| Gábor Hojtsy (he/him) |
Thanks for all of your efforts in making contrib ready for Drupal 10! The ready projects are going up steadily and the errors are going down nicely 🙂 https://dev.acquia.com/drupal10/deprecation_status/charts |
| Gábor Hojtsy (he/him) |
This weekend’s job failed to run so we don’t have the latest data yet, the data there is a week old 🙂 Maybe @hestenet (he/him) can look at why this did not start? https://dispatcher.drupalci.org/job/project_analysis_d10/ |
| Gábor Hojtsy (he/him) |
To put the current state into context, Dries cited this comparison at DrupalCon 🙂 https://twitter.com/gaborhojtsy/status/1572497093238857728 |
| hestenet (he/him) |
I can definitely look |
| Gábor Hojtsy (he/him) |
Thanks! |
| hestenet (he/him) |
Oh boy - java.lang.NullPointerException - https://dispatcher.drupalci.org/job/project_analysis_d10/151/console |
| hestenet (he/him) |
And then a java.lang.NoClassDefFoundError on retry - https://dispatcher.drupalci.org/job/project_analysis_d10/152/console |
| hestenet (he/him) |
After a jenkins restart it seems like it's running - https://dispatcher.drupalci.org/job/project_analysis_d10/153/console:cro... it will complete |
| hestenet (he/him) |
BTW (and I suppose I should copy in @Björn Brala (bbrala)) - what's the state of replacing this jenkins version with a GitLabCI one? |
| hestenet (he/him) |
I guess this was the last update on that (thanks Neil for finding the link) https://drupal.slack.com/archives/C014CT1CN1M/p1661804359354119?thread_t... |
| Gábor Hojtsy (he/him) |
I did not have time to look into taking the data from the new source and updating all the references to the old source from deprecation_status given DrupalCon and personal things since then. |
| Gábor Hojtsy (he/him) |
Maybe my personal stuff winds down a bit :crossed_fingers: so I can take a look. |
| hestenet (he/him) |
No worries!Jenkins is effectively deprecated at this point, so it would be great to find time to move this over fully - but we can limp along until we can find the time. |
| Björn Brala (bbrala) |
I could look tonight or tomorrow if that one didn't fail. But I'm mostly waiting for the bot to support gitlab and the status site :wink: |
| Björn Brala (bbrala) |
It has been running every Sunday steadily. (edited) |
| Björn Brala (bbrala) |
Currently enjoying some beer and crowds :sweat_smile: |
| Björn Brala (bbrala) |
Liberation festival of our city, leiden Netherlands |
| hestenet (he/him) |
Oooh |
| hestenet (he/him) |
Sounds fun! :beers-cheers: |
| Björn Brala (bbrala) |
:smile: |
| Björn Brala (bbrala) |
It is. During the day with the kids though |
| hestenet (he/him) |
That run completed successfully |
| Gábor Hojtsy (he/him) |
https://www.drupal.org/project/infrastructure/issues/3309815 is now updated in the bot code, thanks @tedbow |
| Gábor Hojtsy (he/him) |
We still need to update the bot template text, and I also suggested we make changes to suggest best practices for human interactions with the bot as different people have very different understanding as to how best to use or not use the bot issues. |
| Björn Brala (bbrala) |
There have been multiple discussions on this. I think @Kristen Pol (she/her) got some feedback through the d10 porting days. (edited) |
| Kristen Pol (she/her) |
I would like to work on this. I’ll try to do by Friday but nudges are appreciated:) |
| Tinto |
Thanks for your efforts in this issue @Kristen Pol (she/her)! I know that the discussion leading up to this wasn’t always fun and joy. :wink:I hope we can evaluate this change after a while to (try to) see the effects of this decision. But how to measure? |
| Kristen Pol (she/her) |
Thanks @Tinto … you are very right :wink: as for measuring success, I don’t know… maybe just people not getting mad or switching the issue back if it gets marked RTBC? |
| Tinto |
That would count as a success I guess :yum: |
Comments
Comment #2
gábor hojtsyComment #12
gábor hojtsySaving meeting notes.
Comment #13
gábor hojtsy