Problem/Motivation

DownloadTest fails frequently on SQLite because of performance problems (database locks). A report that show this: https://www.drupal.org/pift-ci-job/2481696

Proposed resolution

I spoke with @xjm and instead of doing major work on fixing the SQLite performance, core contributors have agreed that for now it is better to just skip DownloadTest for SQLite.

We will file a separate issue to fix this test properly.

Issue fork drupal-3311476

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hb76 created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Random test failure
xjm’s picture

xjm
she/her
Primary language English
commented
Parent issue: » #2829040: [meta] Known intermittent, random, and environment-specific test failures
nlisgo’s picture

nlisgo commented

I can take a look at this issue.

nlisgo’s picture

nlisgo commented
Status: Active » Needs review

nlisgo opened merge request !2799

nlisgo’s picture

nlisgo commented
Issue tags: +Prague2022
nlisgo’s picture

nlisgo commented

My merge request should skip the DownloadTest for sqlite but run for other databases. I have a triggered a test with sqlite so that we can verify that the test is skipped.

xjm’s picture

xjm
she/her
Primary language English
commented

This is great, thank you!

The only other thing we need to do here is file the followup to fix it the "right" way (whatever that turns out to be), and add that issue link to the @todo comment instead of the current one.

Adding credit for @hb76 for the issue writeup and myself for mentoring (and @nlisgo for the MR of course).

Spokje made their first commit to this issue’s fork.

spokje’s picture

spokje
Primary language Dutch
commented
Issue tags: -Needs followup
Related issues: +#3311587: Fix root cause frequent database locks on SQLite in DownloadTest and re-enable testing it

Created follow-up issue #3311587: Fix root cause frequent database locks on SQLite in DownloadTest and re-enable testing it and added the URL to the @todo.

spokje’s picture

spokje
Primary language Dutch
commented

How ironic, a random test fail...

Testing Drupal\Tests\ckeditor5\FunctionalJavascript\ImageUrlTest
.................F.                                               19 / 19 (100%)

Time: 04:10.159, Memory: 6.00 MB

There was 1 failure:

1) Drupal\Tests\ckeditor5\FunctionalJavascript\ImageUrlTest::testResize with data set "Image resize is enabled" (true)
Failed asserting that false is identical to true.

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:90
/var/www/html/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestBase.php:644
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

Started retest.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Patch does what the issue summary says; the follow-up exists, so … 🚀

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 789bdf4e23 to 10.1.x and 3c2d9b8d90 to 10.0.x and 9cfe94efe8 to 9.5.x and 36a946272c to 9.4.x. Thanks!

Backported to 9.4.x to help with any security release testing too.

  • alexpott committed 789bdf4 on 10.1.x 
    Issue #3311476 by nlisgo, Spokje, xjm, hb76: Skip DownloadTest on SQLite

  • alexpott committed 3c2d9b8 on 10.0.x 
    Issue #3311476 by nlisgo, Spokje, xjm, hb76: Skip DownloadTest on SQLite...

  • alexpott committed 9cfe94e on 9.5.x 
    Issue #3311476 by nlisgo, Spokje, xjm, hb76: Skip DownloadTest on SQLite...

  • alexpott committed 36a9462 on 9.4.x 
    Issue #3311476 by nlisgo, Spokje, xjm, hb76: Skip DownloadTest on SQLite...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.