Problem/Motivation

The test theme views_test_classy_subtheme stopped using the classy theme in #3112547: Views UI tests should not rely on Classy.

Let's rename the module to reflect that change.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3307296-2.patch3.47 KBspokje

Issue fork drupal-3307296

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Component: Classy theme » views_ui.module
StatusFileSize
new 3307296-2.patch3.47 KB

Well, GitLab is taking for too long to get a branch available, let's go the good ol' patch route

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a simple change and the tests still pass so looks like everywhere it was used was covered.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3307296-2.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Random JS test-failure, back to RTBC with retest ordered to confirm.

  • catch committed 23b92804 on 10.1.x 
    Issue #3307296 by Spokje: Rename test theme views_test_classy_subtheme
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks sensible. Committed/pushed to 10.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.