Problem/Motivation

Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.

Proposed resolution

Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3303033-4.patch4.88 KBbnjmnm
#2 core-3303033-2.patch1.57 KBnod_

Comments

nod_ created an issue. See original summary.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Needs review
StatusFileSize
new core-3303033-2.patch1.57 KB

let's see what breaks

Status: Needs review » Needs work

The last submitted patch, 2: core-3303033-2.patch, failed testing. View results

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs work » Needs review
StatusFileSize
new 3303033-4.patch4.88 KB
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

all good :)

  • lauriii committed d8be557 on 10.1.x 
    Issue #3303033 by nod_, bnjmnm: Book tests should not rely on Classy

  • lauriii committed 38df9b3 on 10.0.x 
    Issue #3303033 by nod_, bnjmnm: Book tests should not rely on Classy

(...

  • lauriii committed 956063d on 9.5.x 
    Issue #3303033 by nod_, bnjmnm: Book tests should not rely on Classy

(...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed d8be557 and pushed to 10.1.x. Also cherry-picked to 10.0.x and 9.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.