Problem/Motivation

Watchdog logs full of Warning: Undefined array key "supports_inline_editing" in Drupal\editor\Plugin\InPlaceEditor\Editor->isCompatible() (line 35 of /mnt/www/html/drupalsite/docroot/core/modules/editor/src/Plugin/InPlaceEditor/Editor.php) after updating Core to 9.4.x and PHP 8.0.x

Steps to reproduce

Authenticated visitors login, and I believe the quick edit module is creating these.
See routes in logs /quickedit/metadata produced I believe by ajax requests for authenticated users.

Proposed resolution

Change file: core/modules/editor/src/Plugin/InPlaceEditor/Editor.php Line: 35

if ($definition['supports_inline_editing'] === TRUE) {
   return TRUE;
}

To first check if array key exists before testing if TRUE

if (isset($definition['supports_inline_editing']) && $definition['supports_inline_editing'] === TRUE) {
   return TRUE;
}

Issue fork drupal-3296222

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

NicholasS created an issue. See original summary.

immaculatexavier’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Bug Smash Initiative, +Needs tests

Seems like a good test scenario

smustgrave’s picture

Status: Needs work » Closed (cannot reproduce)

Please reopen if you are still seeing this issue. With updated issue summary mainly steps to reproduce.

I created a new user who is just authenticated.
Logged in with quickedit module enabled
Verified I'm not seeing any errors in logs.