Problem/Motivation

Ajax, not AJAX or ajax

from the Industry-related words
section of the Drupal content style guide the spelling for Ajax is

Steps to reproduce

git grep AJAX
or this to see a list of files.

git grep AJAX | awk -F: '{print $1}' | sort -u | nl

Proposed resolution

Create child issues to correct the spelling of Ajax throughout core

Remaining tasks

Decide how to divide the work
Create child issues as agreed
See if #2788131: Views UI and misc.js has miscapitalized "Ajax" in UI text is fixing all the UI text.

CommentFileSizeAuthor
#14 3294706-13.patch278.32 KBprabuela
#12 3294706-12.patch1.57 MBAbhisheksingh27
#11 3294706-11.patch1.29 MBrishabh vishwakarma
#9 spelling-mistake-resolve-3294706-9.patch279.5 KBmeeni_dhobale
#5 3294706.patch288.48 KBprabuela

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Title: [Meta} Correct spelling of Ajax » [Meta] Correct spelling of Ajax
Issue summary: View changes

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

prabuela’s picture

prabuela commented
Assigned: Unassigned » prabuela

The AJAX spelling mistake has been changed to "Ajax"

prabuela’s picture

prabuela commented
StatusFileSize
new 3294706.patch288.48 KB
prabuela’s picture

prabuela commented
Assigned: prabuela » Unassigned
Status: Active » Needs work
prabuela’s picture

prabuela commented
Status: Needs work » Needs review
prabuela’s picture

prabuela commented
Status: Needs review » Needs work
meeni_dhobale’s picture

meeni_dhobale commented
StatusFileSize
new spelling-mistake-resolve-3294706-9.patch279.5 KB

The above patch not applying properly. It does not resolve any spelling mistake. Also it ends up with following output

...
...
...
Checking patch core/tests/Drupal/Tests/Core/Form/EventSubscriber/FormAjaxSubscriberTest.php...
Checking patch core/tests/Drupal/Tests/Core/Form/FormBuilderTest.php...
Checking patch core/tests/Drupal/Tests/Core/Render/Element/RenderElementTest.php...
Checking patch core/tests/Drupal/Tests/Core/StackMiddleware/NegotiationMiddlewareTest.php...
Checking patch core/tests/Drupal/Tests/Core/Theme/AjaxBasePageNegotiatorTest.php...
Checking patch core/themes/claro/css/components/views-exposed-form.css...
Checking patch core/themes/claro/css/components/views-exposed-form.pcss.css...

Adding new patch.

In core files somewhere AJAX and ajax used as a variable name. If we try to change this and we missed by mistake a single variable then it will break some functionality. And it is very time consuming + not feasible to check every functionality of Drupal core. So, I skipped those variable to do any changes.

meeni_dhobale’s picture

meeni_dhobale commented
Status: Needs work » Needs review
rishabh vishwakarma’s picture

rishabh vishwakarma commented
StatusFileSize
new 3294706-11.patch1.29 MB

Adding patch

Abhisheksingh27’s picture

Abhisheksingh27 commented
StatusFileSize
new 3294706-12.patch1.57 MB

Adding Patch for the issue

prabuela’s picture

prabuela commented
Assigned: Unassigned » prabuela
prabuela’s picture

prabuela commented
StatusFileSize
new 3294706-13.patch278.32 KB
prabuela’s picture

prabuela commented
Assigned: prabuela » Unassigned
Status: Needs review » Needs work

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.