Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
While rushing to fix critical #3285230: Migrate's DownloadFunctionalTest:: testExceptionThrow() is failing on guzzlehttp/psr7 2.3.0 and @var tag was added incorrectly.
In trait \Drupal\tests\BrowserHtmlDebugTrait::getResponseLogHandler
/* $var \Psr\Http\Message\StreamInterface $stream */
$stream = $response->getBody();
The /* $var. should be /** @var
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3293114
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
mikelutzComment #3
uri_frazierComment #7
uri_frazierComment #8
spokjeMR does what it states on the tin: The
/* $var. should be/* @var.RTBC if TestBot agrees :)
Thanks for working on this!
Oh, and don't be afraid of the
Custom Commands Failedmessage in your first MR.In the case of opening a new MR without having pushed any changes to it, this always happens. If you then push your changes, it will start a new CI run and you will get the actual evaluation of your changes by TestBot.
Comment #9
uri_frazierThanks, Spokje! Thanks especially for the helpful info about the
Custom Commands Failedmessage.Comment #10
spokjeNo worries.
Remember: Normally the message
Custom Commands Failedmeans that some of the changes didn't pass the checks that are done on changed code even before starting the (vast amount) of PHPUnit/Nighwatch tests. Stuff like PHPCS for code style, spelling check and other stuff can cause that message.If you get it when you're _not_ opening an MR without any code changes, like what just happend there's definitely something wrong with your changes (and the reviewer who put it on RTBC :/)
Just click on the actual
Custom Commands Failedmessage, which is a link to see what went wrong, make the appropriate change, git push the changes, which will trigger a new test-run.You're very close, just need to drag it across the finish line!
Putting back to Needs Work for the above.
Comment #11
mikelutzThat was my fault in the initial issue summary, I missed that. Thanks Uri!
Comment #12
uri_frazierGotcha, thanks again! :-)
Comment #13
mikelutzThis is well into running the test suite now, all of which will pass, so back to RTBC.
Comment #14
benjifisherReference: https://www.drupal.org/docs/develop/standards/api-documentation-and-comm...
Comment #16
catchCommitted/pushed to 10.1.x then cherry-picked to 10.0.x, 9.5.x and 9.4.x, thanks!