Problem/Motivation

Part of #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 interdiff_3285136_2-8.patch778 bytesandregp
#8 3285136_8.patch5.39 KBandregp
#6 3285136.patch5.22 KBcatch
#4 3285136.patch3.73 KBcatch
#2 3285136.patch2.36 KBcatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3285136.patch2.36 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Default parameter value removed, fallback code removed, docblock did not mention the NULL option so it does not need updating.

catch’s picture

catch
he/him
Primary language English
commented
Title: Remove constructor bc layer in EntityFieldManager » Remove a couple of constructor bc layers
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3285136.patch3.73 KB

Let's do SiteConfigureForm here too, a bit random but not many left and it's the same type of change.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

The constructor signature needs updating to include the typehints, and there is a section in the docblock about this that can then be removed.

catch’s picture

catch
he/him
Primary language English
commented
Component: entity system » base system
Status: Needs work » Needs review
StatusFileSize
new 3285136.patch5.22 KB

We can also remove DeprecatedServicePropertyTrait and the usage.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

We can also remove this from the docblock:

   *
   * @throws \InvalidArgumentException
   *   Thrown when either the $module_installer or $country_manager parameters
   *   are not of the correct type.
andregp’s picture

andregp commented
Status: Needs work » Needs review
StatusFileSize
new 3285136_8.patch5.39 KB
new interdiff_3285136_2-8.patch778 bytes

@longwave, here is it.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks, this looks good now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ad7357c and pushed to 10.0.x. Thanks!

  • alexpott committed ad7357c on 10.0.x 
    Issue #3285136 by catch, andregp, longwave: Remove  a couple of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.