Closed (fixed)
Project:
Drupal core
Version:
9.5.x-dev
Component:
ckeditor5.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Jun 2022 at 12:47 UTC
Updated:
15 Sep 2022 at 09:44 UTC
Jump to comment: Most recent
Comments
Comment #3
wim leersBased on analysis of https://github.com/ckeditor/ckeditor5/labels/domain%3Aaccessibility by @bnjmnm ~2 weeks ago. @bnjmnm is an accessibility maintainer of Drupal core.
Crediting @bnjmnm.
Comment #4
wim leersUpdate: #10368 is being fixed in https://github.com/ckeditor/ckeditor5/pull/11876 👍
Comment #5
wim leers(Fix markup in issue summary.)
Comment #6
wim leersUpdate: #5581 was fixed in https://github.com/ckeditor/ckeditor5/pull/11869 yesterday! 👍
Comment #7
wim leersComment #8
xjmComment #9
catchQuick update
https://github.com/ckeditor/ckeditor5/issues/11568 - fixed
https://github.com/ckeditor/ckeditor5/issues/11041 - fixed
https://github.com/ckeditor/ckeditor5/issues/3184 - fixed
https://github.com/ckeditor/ckeditor5/issues/10368 and https://github.com/ckeditor/ckeditor5/issues/5146 still open.
Comment #10
wim leersChecked the status of this together with @nod_ and @lauriii.
https://github.com/ckeditor/ckeditor5/issues/3184 was not actually fixed, but closed as a duplicate of https://github.com/ckeditor/ckeditor5/issues/5146, which we already listed.
5146 was marked as in progress 21 days ago, 10368 was marked as in progress 28 days ago.
Comment #11
wim leersComplication: #5581 was marked completed (because its fix was merged), but it was then subsequently reverted. Fortunately, its successor https://github.com/ckeditor/ckeditor5/issues/12067 is on track to fix the problem.
Comment #12
wim leersWe were told #5146 is on track for the CKEditor 5 September release, which is expected to happen in the second half of September, meaning after the Drupal 9.5/10 beta deadline.
Comment #13
wim leersGreat news: we just found out that this is on the verge of being merged; it will probably be merged on Monday, in time for the Aug 24 code freeze & Aug 31 release! 👍
Comment #14
wim leersYay, https://github.com/ckeditor/ckeditor5/pull/12262 was merged one hour ago in https://github.com/ckeditor/ckeditor5/commit/1acdf50abc397aa5d0b0f1c3e5b... (it's so fresh that tests are still running! 🤓)
This is awesome news, because that means all accessibility blockers with the exception of dictation support have been fixed upstream and will be in the Aug 31 release of CKEditor 5!
That means this too needs confirmation from @bnjmnm that the problem is indeed solved.
Comment #15
bnjmnmTested manually on the nightly build and this is successfully addressed.
Comment #16
nod_nice, that means we'll be able to use cke5 widgets for linkit cke5 plugin autocomplete type code.
Comment #17
wim leersYay, thanks @bnjmnm!
Blocked on the Aug 31 release per https://github.com/ckeditor/ckeditor5/issues/12107 then! 🥳 To signal this aspect is done, marking RTBC & titling as postponed.
#16: nice extra win! 😄
Comment #18
wim leersCreated the issue to update core's CKEditor 5, i.e. the issue that this issue is actually blocked on: #3306153: Update CKEditor 5 to 35.1.0.
Comment #19
wim leers#3306153: Update CKEditor 5 to 35.1.0 is in!