Problem/Motivation
From #3260007: Decouple Connection from the wrapped PDO connection to allow alternative clients.
Let's add an @internal tags to Database API methods that should only be called within DB drivers' code - for instance, ::lastInsertId().
List
- Connection::getPrefix() - see #3257201-24: Create the new method Drupal\Core\Database\Connection::getPrefix() and deprecate Drupal\Core\Database\Connection::prefixTable($table)
Proposed resolution
- Find all methods that are eligible to an @internal tag
- Discuss
- Patch
Comments
Comment #2
andypostI recall there was issue to review all doc-blocks of db drivers, so this one could be linked there
Comment #3
mondrakeNote to self: PHPStan has rules around inheritance of @internal classes, let’s make sure we do not break (there’s already an ignored rule in our PHPStan config)
Comment #4
mondrake