Problem/Motivation
Per #3189416: [PP-1] Remove jQuery Form dependency from misc/ajax.js and it's parent issue, jQuery.form is among the libraries we should mark internal to facilitate easier future removal.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3280359-4-10x.patch | 3.75 KB | bnjmnm |
| #5 | 3280359-4-94x.patch | 5.7 KB | bnjmnm |
| #2 | 3280359-2-94x.patch | 2.23 KB | bnjmnm |
| #2 | 3280359-2-10x.patch | 1.74 KB | bnjmnm |
Comments
Comment #2
bnjmnmComment #5
bnjmnmUpdated vendor updates and changed additional uses of core/jquery.form
Comment #6
nod_Looking good to me
Comment #8
catch10.x and 9.x patches both look commit - committed/pushed to 10.x and 9.5.x/9.4.x respectively.
Comment #10
effulgentsia commentedI'm very happy this got in. Let's add a change record for it.
Comment #11
joachim commentedIs this change the reason why I've had to add
$form['#attached']['library'][] = 'core/jquery.form';to forms in Module Builder, because the AJAX buttons have suddenly started crashing with a JS function not found popup?If so, this really needed a change record before it was committed and made it into a release!
Comment #12
effulgentsia commentedHm, #11 is unexpected. How was jquery.form being added in Module Builder in Drupal 9.3? If it was via the rendering of an element with a #ajax property, then in Drupal 9.4, #5 made that now bring in
internal.jquery.formwhich is the same JS files, so shouldn't error from missing a JS function.Comment #13
bnjmnm@joachim You are correct that this should have a change record, so I made one. #3293156: core/jquery.form library deprecated
However, it's not clear to me that the changes here would cause the symptoms you reported given the solution you said fixed it:
core/jquery.formtriggers a deprecation warning but is still fully available and otherwise unchanged. If there was code trying to load this library in Drupal 9, it would still be there.core/jquery.formno longer exists so there would be a problem if something was trying to load it, but then the solution you reported:would not work because that library no longer exists.
Perhaps the above can help narrow down what is going on with Module Builder.