Problem/Motivation

JsonApiDocumentTopLevelNormalizerTest::generateProphecies($entity_type_id, $bundle) is called with an extra argument quite a few times. Those need to be removed.

Example:

[$request, $resource_type] = $this->generateProphecies('node', 'article', 'uid'); 

should be 

[$request, $resource_type] = $this->generateProphecies('node', 'article');

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 json-api-3280302-9.patch2.41 KBanoopsingh92
#5 json-api-3280302-5.patch2.4 KBarunkumark
#2 3280302-2.patch2.41 KBshashwat purav

Issue fork drupal-3280302

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bbrala created an issue. See original summary.

shashwat purav’s picture

shashwat purav commented
Status: Active » Needs review
StatusFileSize
new 3280302-2.patch2.41 KB

Added patch to remove extra argument.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

The changes look good. I've checked the code if there were any other ones left over, but you seemed to have catched them all, well done :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3280302-2.patch, failed testing. View results

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Needs work » Needs review
StatusFileSize
new json-api-3280302-5.patch2.4 KB

Patch has been re-rolled for the latest version of 9.5.x.

hlopez’s picture

hlopez commented
Status: Needs review » Reviewed & tested by the community

Still looks good, moving back to RTBC

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: json-api-3280302-5.patch, failed testing. View results

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: Unassigned » anoopsingh92
anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: anoopsingh92 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new json-api-3280302-9.patch2.41 KB

Patch has been re-rolled for 9.5.x please review this.

pflora’s picture

pflora commented
Status: Needs review » Reviewed & tested by the community

I've reviewed the patch and everything seems to be working fine. I also ran the tests and everything passed! Moving it to RTBC!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Eventually phpstan will catch stuff like this for us. I've checked that this is not in the baseline in 10.x yet so doesn't fail on that env atm.

Committed and pushed f27dc02c28 to 10.1.x and 96ec16f909 to 10.0.x and e6df71a634 to 9.5.x. Thanks!

Will cherry pick to 9.4.x once 9.4.5 is released.

  • alexpott committed f27dc02 on 10.1.x 
    Issue #3280302 by anoopsingh92, Shashwat Purav, arunkumark, bbrala:...

  • alexpott committed 96ec16f on 10.0.x 
    Issue #3280302 by anoopsingh92, Shashwat Purav, arunkumark, bbrala:...

  • alexpott committed e6df71a on 9.5.x 
    Issue #3280302 by anoopsingh92, Shashwat Purav, arunkumark, bbrala:...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Patch (to be ported) » Fixed

Committed d669774 and pushed to 9.4.x. Thanks!

Oops forgot about this one.

  • alexpott committed d669774 on 9.4.x 
    Issue #3280302 by anoopsingh92, Shashwat Purav, arunkumark, bbrala:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.