Problem/Motivation

This is a follow up to #2254785: Progress bar 0% or over 100% visual BUG.

I'd like to still push this to 2 or 1%.

From comment #20.

Steps to reproduce

TBA

Proposed resolution

Determine if the width should be reduced from 3 to 1 or 2 percent.

Remaining tasks

TBD

User interface changes

Before and after screenshots needed.

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#9 olivero-progress-bar-2%.png56.53 KBsheetal.pathak
#9 olivero-progress-bar-3%.png39.62 KBsheetal.pathak
#4 2254785-35.patch979 bytesquietone

Issue fork drupal-3270657

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone credited komalk.

quietone credited samiullah.

quietone’s picture

quietone commented
StatusFileSize
new 2254785-35.patch979 bytes

Here is the latest patch and the screenshots from #2254785-35: Progress bar 0% or over 100% visual BUG

progress bar with 1%
progress bar with 3%

Testing was done in a later comment with these screenshots.
Start of process
End of process

It seems that this should have screenshots for 2% in order to evaluate if 1% is better than 2%.

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mstrelan’s picture

mstrelan commented
Component: system.module » CSS

Not sure I follow entirely, but it seems to me the issue is with progress bars that have a border radius (e.g. Olivero and Claro, but not the one in core/misc). Perhaps we can use calc to offset the border radius on each side of the progress track and see how it looks from there.

sheetal.pathak made their first commit to this issue’s fork.

sheetal.pathak opened merge request !12505

sheetal.pathak’s picture

sheetal.pathak commented
StatusFileSize
new olivero-progress-bar-3%.png39.62 KB
new olivero-progress-bar-2%.png56.53 KB

Created MR for setting progress bar with to 2%
Added width for progress bar for Olivero theme as only, as in Claro it is working fine.
Added Screenshot for 2% width Progress bar.

Please review.

sheetal.pathak’s picture

sheetal.pathak commented
Status: Active » Needs review
libbna’s picture

libbna commented
Assigned: Unassigned » libbna

I will review in sometime.

libbna’s picture

libbna commented
Assigned: libbna » Unassigned

I am unassigning it as I was not able to reproduce this issue.

Steps I followed:

  1. Changed the theme to "olivero"
  2. Tried to create a new field and save it. The progress bar didn't show up.
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update, +Needs steps to reproduce

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.