Problem/Motivation

If you have a site with an obsolete extension that is still installed, the status report currently says:

Obsolete extensions found: %extensions. Obsolete extensions are provided only so that they can be uninstalled cleanly. You should immediately uninstall these extensions since they may be removed in a future release.

#3266308: %extensions placeholder not extension names printed on the Status report warning about obsolete extensions will fix the bug that the %extensions placeholder isn't getting the values replaced. But it leaves the problem that site owners won't necessarily know how to fix this problem and silence the warning.

Steps to reproduce

  1. Start with a Drupal core 9.4.x test site
  2. Create a new module test and install it, you can use the following .info.yml file:
    name: 'Test module'
    type: module
    description: 'Test module'
    package: Testing
    version: VERSION
    core_version_requirement: ^8 || ^9
      
  3. Go to /admin/modules and install the module
  4. Change the info file and add the lifecycle obsolete:
    lifecycle: obsolete
    lifecycle_link: 'https://example.com/obsolete'
    
  5. Rebuild the cache
  6. Go to admin/reports/status and check the warnings

Proposed resolution

Convert the words "uninstall these extensions" into a link to the Uninstall form at /admin/modules/uninstall.

Remaining tasks

  1. Decide if we need to be fancy about if it's only an obsolete theme (?!?) or if it's cool to always link to the modules Uninstall form.
  2. Land #3266308: %extensions placeholder not extension names printed on the Status report warning about obsolete extensions
  3. Add the link
  4. Update test coverage
  5. Reviews/refinements
  6. RTBC

User interface changes

The warning on the status report when a site has an obsolete extension installed includes the words "uninstall these extensions" which is now a link to the Uninstall page at /admin/modules/uninstall.

Before

before

After

after

API changes

None.

Data model changes

None.

Release notes snippet

TBD, probably not.

Comments

dww created an issue. See original summary.

dww’s picture

StatusFileSize
new1.19 KB

This includes the fix from #3266308: %extensions placeholder not extension names printed on the Status report warning about obsolete extensions and will need tests before it's commit-able, but here's a start (from @murilohp).

dww credited murilohp.

dww’s picture

dww’s picture

Title: [PP-1] Add a link to the Status report warning about obsolete extensions so site owners can fix the problem » Add a link to the Status report warning about obsolete extensions so site owners can fix the problem
Status: Postponed » Needs work
Issue tags: +Needs tests
StatusFileSize
new1.1 KB

Yay, blocker is in. Here's a re-roll of #2 for 9.4.x branch. Still no new tests, so no sense having the bot waste cycles on this.

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new1.41 KB
new1.56 KB
new2.66 KB

Is this sufficient for a test?

dww’s picture

Issue tags: -Needs tests

WFM.😉 Thanks!

The last submitted patch, 6: 3266449-6-fail.patch, failed testing. View results

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative
StatusFileSize
new58.23 KB
new61.61 KB

Tested this on Drupal 10.1 with a standard install
Installed admin_toolbar
Added

lifecycle: obsolete
lifecycle_link: 'https://example.com/obsolete'

Went to status report verified I saw the message
Applied patch #6
Verified uninstall these extensions was now linked.

Added before/after screenshots to IS.

  • catch committed 999e16ad on 10.1.x
    Issue #3266449 by quietone, dww, smustgrave, murilohp: Add a link to the...
catch’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +String change in 10.1.0

Committed 999e16a and pushed to 10.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.