Problem/Motivation

There's functions deprecated for removal in core 10

Proposed resolution

remove the usage, make sure no mentions left

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

CommentFileSizeAuthor
#2 3264059-2.patch6.88 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

Status: Active » Needs review
StatusFileSize
new6.88 KB

not a lot

daffie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

quietone’s picture

Status: Reviewed & tested by the community » Needs work

Looks like there are few more.

core/modules/jsonapi/src/Context/FieldResolver.php:      @trigger_error('Calling ' . __METHOD__ . '() without the $current_user argument is deprecated in drupal:9.3.0 and will be required in drupal:10.0.0.', E_USER_DEPRECATED);
core/modules/jsonapi/src/Access/RelationshipFieldAccess.php:    @trigger_error(sprintf("The %s access check is deprecated in drupal:9.2.0 and is removed from drupal:10.0.0. There is no replacement. JSON:API's route access checks are internal. See https://www.drupal.org/node/3194641.", static::ROUTE_REQUIREMENT_KEY), E_USER_DEPRECATED);
core/modules/jsonapi/src/Normalizer/LinkCollectionNormalizer.php:      @trigger_error('Calling ' . __METHOD__ . '() without the $current_user argument is deprecated in drupal:9.2.0 and will be required in drupal:10.0.0.', E_USER_DEPRECATED);
andypost’s picture

Status: Needs work » Reviewed & tested by the community

@quietone exactly this 3 palaces are in patch, looks you did not apply it

quietone’s picture

@andypost, I apologize.

I reviewed again taking more care and yes, this does remove all the deprecations for json api module, that is the following return no results.

grep -r "@deprecated" core | grep -v "node_modules" | grep -i json
grep -r "@group legacy" core | grep -v "node_modules" | grep -i json
grep -r "@trigger" core | grep -v "node_modules" | grep -i json

This looks ready to commit to me. I'll wait for another committer to confirm.

bbrala’s picture

Nice one cleaning this up.

+1 RTBC

catch’s picture

Looks good here too. I think quietone was planning to commit this one so leaving RTBC for that.

  • quietone committed cc7876e on 10.0.x
    Issue #3264059 by andypost: Remove deprecated jsonapi module functions
    
quietone’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 10.0.x.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.