Problem/Motivation

composer/installers 2.0.0 was released a few months ago: https://github.com/composer/installers/releases/tag/v2.0.0

Steps to reproduce

Proposed resolution

Upgrade to 2.x.

Remaining tasks

Do the upgrade, see what breaks, and fix it.
Determine if we can add support for both 1.x and 2.x in Drupal 9.4.
Decide if we want to support both 1.x and 2.x in Drupal 10.

User interface changes

API changes

Data model changes

Release notes snippet

New Drupal 10 site development now requires composer/installers version 2.0 or higher (up from version 1.9), and the default version is now 2.0.1.

CommentFileSizeAuthor
#11 3253059-11.patch6.07 KBlongwave
#5 interdiff-3_5.txt841 bytesspokje
#5 3253059-5.patch5.84 KBspokje
#3 3253059-3.patch4.79 KBspokje
#2 3253059-2.patch5.7 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3253059-2.patch5.7 KB
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3253059-3.patch4.79 KB

Looks like #2 got hit by the committing of #3252088: Increase Drupal::MINIMUM_PHP to 8.0.0. Rerolled.

Status: Needs review » Needs work

The last submitted patch, 3: 3253059-3.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3253059-5.patch5.84 KB
new interdiff-3_5.txt841 bytes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Drupal 10
Parent issue: » #3215870: Require Composer 2.3.5 for developing Drupal 10 core

Closed #3265124: Update composer/installers to ^2.0 as a duplicate of this issue.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work

This will need a reroll.

I'm not sure we should support both 1.9 and 2.0 given that we don't have min-max testing. Not sure though; maybe we could do that for 9.4. For Drupal 10, we might want to make 2.0 the minimum.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I don't think we need to support 1.9 any more. 2.0's breaking changes don't affect us - they are a bump to minimum PHP 7.3, which we are already on or exceeding, and the removal of some PHP frameworks that don't concern us.

We reference composer/installers:^1.9 in four relevant places:

  1. root composer.json - this is only used by core developers, and we can bump dependencies here without affecting our users
  2. root composer.lock - this is normally used by the code that builds drupal/core-recommended, but there is explicit code to exclude composer/installers from core-recommended
  3. composer/Template/RecommendedProject/composer.json - this is used at composer create-project time only; existing users will stay on their current version
  4. composer/Template/LegacyProject/composer.json - same as above

Therefore I think this is safe to bump in composer.json and the two project templates directly to ^2.0.

We also mention it indirectly in composer/Plugin/Scaffold/README.md and we should probably bump the version number there at the same time.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3253059-11.patch6.07 KB

Rerolled for ^2.0 only, also updated scaffold readme.

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Major
Issue summary: View changes
Issue tags: +10.0.0 release notes

Adding a release note.

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Major » Normal

I read over the composer/installers package information and 2.0.0 release notes and I agree with #10; this seems like a safe increase based on that info. (Also if there are any issues, we'll find out sooner rather than later by increasing the requirement before the next alpha.) Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Major

Also crossposted with myself apparently.

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Major » Normal
Issue summary: View changes
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

The patch updates the package "composer/installers" to version 2.0.
Looks good to me.

  • xjm committed 752ad02 on 10.0.x 
    Issue #3253059 by Spokje, longwave, xjm: Upgrade to composer/installers...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed to 10.0.x. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Shouldn't we have a change record for this?

xjm’s picture

xjm
she/her
Primary language English
commented

@Wim Leers, no, we don't provide change records for dependency updates that don't result in public API changes. Just release notes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.