Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
We changed the ds9.txt file in #3209934: Fix spelling for 46 migrate related words but we didn't update the file_managed table
Steps to reproduce
Proposed resolution
Update the file size in drupal7.php
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3246053-2.patch | 501 bytes | quietone |
| #2 | 3246053-2.txt | 501 bytes | quietone |
Comments
Comment #2
quietone commentedThe size of this file, ds9.txt. is not tested in a core migration test so the change was not picked up. In order to add a test FileMigrationSetupTrait needs to be modified to handle more that one file. Currently, I don't think that work is necessary because the file migration is tested and no new files are being added to the fixture. Of course the latter one may change but right now I can't think of any open issue that would require that. The problem arose from doing spelling change fixes to the file ds9.txt and that will not happen again because the file only contains, the '*' character.
And just to note that there is an issue to update the fixture, #3219539: Update Drupal 7 migration database fixture which has some activity this week.
Comment #3
quietone commentedThat was meant to be a patch.
Comment #4
longwaveThe file is now 4 bytes so this is correct. There are two references to ds9.txt in the codebase and only one mentions the file size, so there are no other changes to make here.
Comment #5
quietone commentedI think this qualifies as a quick fix.
Comment #6
alexpottTest-only fix backported to 9.3.x.
Committed and pushed a911353469 to 9.4.x and 52524c98bc to 9.3.x. Thanks!