Problem/Motivation

This issue has been created as a follow up for #3220437-36: [PP-1] Empty breadcrumb at node/add and node/add/{content_type} when frontpage view is enabled

In issue #3220437: [PP-1] Empty breadcrumb at node/add and node/add/{content_type} when frontpage view is enabled, we have added a Breadcrumb Builder service. This was designed to be only a backwards-compatibility layer.

Proposed resolution

Remove the backwards compatibility layer introduced in #3220437: [PP-1] Empty breadcrumb at node/add and node/add/{content_type} when frontpage view is enabled (including the Breadcrumb Builder), and move the node/add/{content type} paths to sit under admin/content.

Remaining tasks

  1. Figure out how to handle the existing "Use admin theme" config option, which allows toggling whether the admin theme is used for node add and edit pages (see comment #5 for more technical details);
  2. Remove the breadcrumb builder;
  3. Change node creation paths such that it sits under admin/content;
  4. Get approval from UX team.

User interface changes

API changes

Data model changes

Release notes snippet

Comments

mohit_aghera created an issue. See original summary.

mohit_aghera’s picture

mohit_aghera commented
Title: Remove dedicated "node.breadcrumb" breadcrum builder » Remove dedicated "node.breadcrumb" breadcrumb builder
aaronmchale’s picture

aaronmchale
Primary language English
Location Edinburgh, Scotland
commented
Issue summary: View changes

Updated IS to use proper issue links and added a bit of formatting.

Removed "Create redirects for older paths for backward compatibility." from proposed resolution steps as we are removing the BC-layer in this issue.

Moved Proposed Resolution steps to sit under Remaining Tasks.

Refactored Problem and Proposed Resolution sections, we don't need a "Steps to reproduce" section.

aaronmchale’s picture

aaronmchale
Primary language English
Location Edinburgh, Scotland
commented
Title: Remove dedicated "node.breadcrumb" breadcrumb builder » [PP-1] Remove dedicated "node.breadcrumb" breadcrumb builder
Status: Active » Postponed

Obviously this is blocked on #3220437: [PP-1] Empty breadcrumb at node/add and node/add/{content_type} when frontpage view is enabled.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Moving the node/add pages under admin/ is really quite a big change that needs quite a lot more work than is suggested in the issue summary, There is a toggle to display node creation pages in the frontend theme i.e. not the admin theme. This will break the moment we move the node creation paths. At the moment \Drupal\node\EventSubscriber\NodeAdminRouteSubscriber takes care of marking these non-admin paths as admin paths if the node_settings::use_admin_theme config is set to TRUE. All of this will need much thought. Also the entire use case of user generated content will be affected.

aaronmchale’s picture

aaronmchale
Primary language English
Location Edinburgh, Scotland
commented
Issue summary: View changes

@alexpott Great points there, thanks. I've added "Figure out how to handle the existing "Use admin theme" config option" as a remaining task.

Also the entire use case of user generated content will be affected.

Yeah that's a really important point, and definitely worth exploring. Definitely implications for #3220437: [PP-1] Empty breadcrumb at node/add and node/add/{content_type} when frontpage view is enabled (which we're already discussing over there).

One example of that user generated content, off the top of my head, would be for a site using the Forum module, when creating a new topic, for end users you would want them to stay in the context of the site frontend and not take them out of that experience into the admin experience.

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

acbramley’s picture

acbramley commented
Title: [PP-1] Remove dedicated "node.breadcrumb" breadcrumb builder » [PP-2] Remove dedicated "node.breadcrumb" breadcrumb builder

This is blocked behind 2 issues now. I'm also personally not a fan of moving node/add under admin/content for reasons described in #5

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.