Problem/Motivation

8.9.x still supports PHP 7.0 until its end-of-life on November 2, 2020.

HEAD has been failing on PHP 7.0 since December due to erroneously backported void typehints for the setUp() method in phpunit tests.

While there is a low risk of this affecting anything other than core development since this is only test code, it does put in a situation where an actual functional regression on PHP 7.0 will be hard to spot due to the noise of failing tests.

Proposed resolution

Get rid of the incorrectly backported void typehints and fix any future backports.

Remaining tasks

User interface changes

N/A

API changes

None.

Data model changes

None.

Release notes snippet

N/A

Issue fork drupal-3225960

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xjm created an issue. See original summary.

xjm opened merge request !985

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review

quietone made their first commit to this issue’s fork.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review

Thanks @quietone for the fix.

Undid some overzealous string-replace changes that broke the PHPUnit 7 compatibility magic; hopefully this should pass on PHP 7.3 again.

xjm’s picture

xjm
she/her
Primary language English
commented

Duh, did not need to queue the PHP 8 environment because 8.9 does not support PHP 8.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Looks now it pass

  • catch committed 4be9fce on 8.9.x 
    Issue #3225960 by xjm, quietone: Make 8.9.x HEAD pass on PHP 7.0 by...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 4be9fce and pushed to 8.9.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.