Problem/Motivation

The 'Display error message' setting in the taxonomy_index_tid views filter ('Has taxonomy term ID') is not used. The functionality that used it, was removed in #2428881: Remove TermAutocompleteController::autocompletePerVid(), without removing the setting. It is now unnecessary clutter in the user interface.

Steps to reproduce

Add the 'Has taxonomy term ID' filter to a view, expose the filter. The setting appears.

Proposed resolution

Remove the setting.

Remaining tasks

Implementation & review.

User interface changes

Removes redundant form element.

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 After Patch 3214554 one.png275.32 KBchetanbharambe
#5 After Patch 3214554.png445.72 KBchetanbharambe
#5 Before Patch 3214554.png437.53 KBchetanbharambe
#4 before_patch.png111.14 KBakhildev.cs
#4 after_patch.png111.89 KBakhildev.cs
#3 taxonomy-views-filter-error-setting-3214554-3.patch4.53 KBjames.williams
#2 taxonomyfilter.png109.04 KBjames.williams

Comments

james.williams created an issue. See original summary.

james.williams’s picture

james.williams
Location Coventry, UK
commented
Version: 10.0.x-dev » 9.3.x-dev
StatusFileSize
new taxonomyfilter.png109.04 KB
james.williams’s picture

james.williams
Location Coventry, UK
commented
Status: Active » Needs review
StatusFileSize
new taxonomy-views-filter-error-setting-3214554-3.patch4.53 KB

Here's a patch that removes the setting, and removes it from configuration exports using it. Is a [post-]update hook needed to remove the property from any saved configuration that's using it?

akhildev.cs’s picture

akhildev.cs commented
StatusFileSize
new after_patch.png111.89 KB
new before_patch.png111.14 KB

hi james,
patch #3 applied cleanly and removed settings.
thank you.

chetanbharambe’s picture

chetanbharambe commented
StatusFileSize
new Before Patch 3214554.png437.53 KB
new After Patch 3214554.png445.72 KB
new After Patch 3214554 one.png275.32 KB

Verified and tested patch #3.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: admin/structure/views/view/taxonomy_term
# Add Content:Tags under filter criteria
# Click on added tag
# User is able to see "Display Error Message" with checkbox.

Expected Results:
# User should not see "Display Error Message" with the checkbox.

Actual Results:
# Taxonomy views filter Display error message setting is redundant

Note: If "Display Error Message" with a checkbox is removed then still the User is able to see a validation error message which is wrong behaviour.
Can be a move to +1 RTBC

tuuuukka’s picture

tuuuukka commented

Applied and tested patch #3, works like a charm.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs subsystem maintainer review

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Tested again in D10 on the main content view
Adding a filter for tags exposed
Search for a term that doesn't exist I get the error.

Apply the patch
Still get the same results.

Tagging for subsystem maintainer review for their thoughts.

patch will have to be updated for D10 though as it doesn't cleanly apply.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.