Problem/Motivation

While creating a custom basic block through layout builder, the Display title checkbox below the input field description is misaligned.

Steps to reproduce

1. Home>Administration>Structure>Content types>Article,under layout options check layout builder.
2. Go to the article node, click on layout.
3. Click on Add block, create a custom block>basic block.
4. The Display title checkbox below the input field description is misaligned.

CommentFileSizeAuthor
#8 chrome_21-11-12_733.jpg132.84 KBbskibinski
#3 after-3213557.png48.65 KBguilhermevp
#3 before-3213557.png46.73 KBguilhermevp
#2 3213557.2.patch772 bytesSakthivel M
Screenshot 2021-05-12 at 10.13.10 AM.png201.06 KBtushar_sachdeva
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tushar_sachdeva created an issue. See original summary.

Sakthivel M’s picture

Sakthivel M CreditAttribution: Sakthivel M at QED42 for Drupal India Association commented
Status: Active » Needs review
FileSize
3213557.2.patch772 bytes

#2 Please review the patch

guilhermevp’s picture

guilhermevp CreditAttribution: guilhermevp at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
before-3213557.png46.73 KB
after-3213557.png48.65 KB

Patch indeed makes it looks better and aligned.

Before:
before

After:
after

  • lauriii committed 3153340 on 9.3.x 
    Issue #3213557 by Sakthivel M, guilhermevp, tushar_sachdeva: Display...

  • lauriii committed 791b06c on 9.2.x 
    Issue #3213557 by Sakthivel M, guilhermevp, tushar_sachdeva: Display...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 3153340 and pushed to 9.3.x and 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bskibinski’s picture

bskibinski
Primary language Dutch
Location Breda, The Netherlands
CreditAttribution: bskibinski at iO commented
FileSize
chrome_21-11-12_733.jpg132.84 KB

This fix breaks checkboxes in Claro. this should be scoped more to the issue at hand.
What frontend theme was used to test this? In the default seven theme, the checkbox doesn't even get the class "form-type--boolean".

When setting Claro as the default theme (for frontend) the checkbox also breaks.

Created a new bug ticket to fix this patch: https://www.drupal.org/project/drupal/issues/3249141

But this issue will probably need a proper fix, not sure if this ticket should be reopend?