Problem/Motivation

CKEditorLoadingTest::testExternalStylesheets() does not perform any functional tests, it only uses the theme installer and related services.

Steps to reproduce

Proposed resolution

Convert it to a kernel test.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3211474.patch5.1 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave as a volunteer commented
Status: Active » Needs review
FileSize
3211474.patch5.1 KB

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

One test method has been moved from a browserbased test to a kernelbased test.

It all looks good to me.

  • catch committed 011f0e9 on 9.3.x 
    Issue #3211474 by longwave, daffie: CKEditorLoadingTest::...

  • catch committed ebb04d6 on 9.2.x 
    Issue #3211474 by longwave, daffie: CKEditorLoadingTest::...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.