Problem/Motivation
We use Symfony\Component\Mime classes directly but don't have a direct dependency.
Proposed resolution
Add symfony/mime to core/composer.json
It's already part of the build...
$ composer why symfony/mime
symfony/http-foundation v4.4.20 requires symfony/mime (^4.3|^5.0)
Remaining tasks
User interface changes
N/a
API changes
N/a
Data model changes
N/a
Release notes snippet
N/a
Issue fork drupal-3207456
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3207456-drupal-9-is
changes, plain diff MR !503
Comments
Comment #2
spokjeComment #4
longwaveWe need to update the lock file. There is also the issue that we already have symfony/mime 5.2.6 in the lockfile, so we should probably depend on
symfony/mime:^5.2rather than downgrading everyone at this point?Comment #5
longwaveOr should we just copy
symfony/http-foundation's constraint? I guess there is the possibility of contrib or custom code already depending onsymfony/mime:^4but not yet allowing 5.x?Comment #6
spokje@longwave:
Since the lock file in the root directory already has:
I don't think Contrib can depend on
symfony/mime:^4?Looking at my previous fail here it won't even install as far as I can tell?
Comment #7
spokjeComment #9
spokjeRebased MR against
9.3.x.Comment #10
longwaveThis just adds the dependency to composer.json without changing the version in the lockfile, this is all we need to do here.
Comment #13
catchCommitted/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!