Problem/Motivation

We use Symfony\Component\Mime classes directly but don't have a direct dependency.

Proposed resolution

Add symfony/mime to core/composer.json

It's already part of the build...

$ composer why symfony/mime
symfony/http-foundation  v4.4.20  requires  symfony/mime (^4.3|^5.0)

Remaining tasks

User interface changes

N/a

API changes

N/a

Data model changes

N/a

Release notes snippet

N/a

Issue fork drupal-3207456

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

Spokje’s picture

Assigned: Unassigned » Spokje

longwave’s picture

Status: Active » Needs work

We need to update the lock file. There is also the issue that we already have symfony/mime 5.2.6 in the lockfile, so we should probably depend on symfony/mime:^5.2 rather than downgrading everyone at this point?

longwave’s picture

Or should we just copy symfony/http-foundation's constraint? I guess there is the possibility of contrib or custom code already depending on symfony/mime:^4 but not yet allowing 5.x?

Spokje’s picture

@longwave:

Since the lock file in the root directory already has:

            "name": "symfony/mime",
            "version": "v5.2.6",

I don't think Contrib can depend on symfony/mime:^4?

Looking at my previous fail here it won't even install as far as I can tell?

Spokje’s picture

Assigned: Spokje » Unassigned
Status: Needs work » Needs review

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Spokje’s picture

Rebased MR against 9.3.x.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

This just adds the dependency to composer.json without changing the version in the lockfile, this is all we need to do here.

  • catch committed d59f858 on 9.3.x
    Issue #3207456 by Spokje, longwave, alexpott: Drupal 9 is dependent on...

  • catch committed d69c7eb on 9.2.x
    Issue #3207456 by Spokje, longwave, alexpott: Drupal 9 is dependent on...
catch’s picture

Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.