Problem/Motivation

D7 tests with PHP 8.0 currently hit these failures:

Form element validation 315 passes, 3 fails, and 0 exceptions

The test class is: Form element validation (FormsTestCase)

Steps to reproduce

Looking at e.g. https://www.drupal.org/pift-ci-job/2017309 the failures are:

testCheckboxProcessing

fail: [Other] Line 253 of modules/simpletest/tests/form.test:
Checkbox 'disabled_checkbox_off' returns expected value (expected: '', got: 0)

fail: [Other] Line 253 of modules/simpletest/tests/form.test:
Checkbox 'checkbox_off' returns expected value (expected: '', got: 0)

fail: [Other] Line 253 of modules/simpletest/tests/form.test:
Checkbox 'zero_checkbox_off' returns expected value (expected: '', got: 0)

Proposed resolution

Fix D7 so these tests pass.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3206428

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mcdruid created an issue. See original summary.

mcdruid’s picture

mcdruid commented
Issue summary: View changes
mcdruid’s picture

mcdruid commented
Issue summary: View changes
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: -PHP 8 +PHP 8.0
taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Related issues: +#642820: PHP notice when submitting form with disabled checkbox

Taran2L opened merge request !477

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Active » Needs review

This is a test-only issue: empty string is no longer equal to zero in PHP8.0+

mcdruid’s picture

mcdruid commented
Status: Needs review » Reviewed & tested by the community

LGTM, thanks!

ayesh’s picture

ayesh commented

+1 Confirming this works, Thank you.

  • mcdruid committed 98fedad on 7.x 
    Issue #3206428 by Taran2L: [PHP 8] test failures in Form element...
mcdruid’s picture

mcdruid commented
Status: Reviewed & tested by the community » Fixed

Thank you!

mcdruid closed merge request !477

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.