Inside the CSS file "core/modules/system/css/components/align.module.css"
replace :

.align-center {
  display: block;
  margin-right: auto;
  margin-left: auto;
}

with :

.align-center { 
  display: flex; 
  justify-content: center; 
}
CommentFileSizeAuthor
#14 after_patch10.png129.41 KBsonam.chaturvedi
#14 before_patch10.png138.78 KBsonam.chaturvedi
#10 3205025-10.patch439 bytesindrajithkb
#5 3205025-5.patch475 bytesdjsagar

Issue fork drupal-3205025

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

steveoriol created an issue. See original summary.

steveoriol opened merge request !453

steveoriol opened merge request !463

djsagar’s picture

djsagar commented
Assigned: steveoriol » Unassigned
djsagar’s picture

djsagar commented
Status: Active » Needs review
StatusFileSize
new 3205025-5.patch475 bytes

Hi steveoriol,

I just converting you comment on patch for class align-center issue.

Please review and feedback, Please letc me know if i'm doing something wrong.

Thanks!

steveoriol’s picture

steveoriol
Location Grenoble 🇫🇷
commented

Hello djsagar,
I am no longer sure that this modification works for everyone and in all cases, maybe it is better to make this modification by overwriting it directly in the sub-theme chosen for the site ...?
There is also, not only the file "core/modules/system/css/components/align.module.css" to modify but also "core/themes/stable/css/system/components/align.module.css" and perhaps other too ...
Thank you.

steveoriol closed merge request !463

mitthukumawat’s picture

mitthukumawat commented

Patch #5 applied cleanly for me. The current CSS for core/modules/system/css/components/align.module.css is looking fine.

djsagar’s picture

djsagar commented
Assigned: Unassigned » djsagar

Thanks @mitthukumawat will resolved Custom Commands Failed issue and re-rolling patch.

indrajithkb’s picture

indrajithkb commented
Version: 9.1.x-dev » 9.3.x-dev
StatusFileSize
new 3205025-10.patch439 bytes

Hi @djsagar thanks for the patch, here am re-rolling the patch with 9.3.x-dev please review the patch.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni commented

Applied patch #10 in durpal-9.3.x-dev applied successfully.
core/modules/system/css/components/align.module.css has been modified and looking good for me
Thanks for the patch.....

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

sonam.chaturvedi’s picture

sonam.chaturvedi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch10.png138.78 KB
new after_patch10.png129.41 KB

Verified and tested patch#10 on 9.5.x-dev. Patch applied successfully.

Test Result:
core/modules/system/css/components/align.module.css is updated to:

.align-center {
  display: flex;
  justify-content: center;
}

Before patch:
before change

After patch:
after change

Moving to RTBC

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Would it be possible to get more information what is the reported bug here? I think we should potentially change all of the align-* classes to use flexbox but since this is reported as a bug, I'm curious to what is the bug we are solving.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: djsagar » Unassigned
Issue tags: +Bug Smash Initiative, +Needs steps to reproduce

Triaging for bugsmash so tagging. Since this is reported as a bug, we need steps to reproduce starting with a vanilla Drupal install. Thanks.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since there hasn't been a follow up to #15 or #17 going to close for now.

If still an issue please reopen adding steps to reproduce this issue.

Thanks all!