Problem/Motivation
I was looking at some code related to views exposed forms and noticed something weird in Drupal\views\ExposedFormCache.
This class is supposed to set/get the form cache, but setForm method actually does this:
public function setForm($view_id, $display_id, array $form_output) {
// Save the form output.
$views_exposed[$view_id][$display_id] = $form_output;
}
As a result, getForm is always return FALSE.
Proposed resolution
Let's make it work.
Remaining tasks
Review, commit.
Issue fork drupal-3198152
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3198152-views-exposed-form-cache
changes, plain diff MR !310
Comments
Comment #3
matroskeenCurious to see if it breaks something :)
Comment #6
matroskeenLol, turns there is a duplicated issue, created a while ago: #2913497: ExposedFormCache invalid logic.
I should have checked better at that time. Closing :)