The Drupal Core Mentoring Coordinators are delighted to invite AmyJune Hineline (volkswagenchick) to the list of Provisional Mentoring Coordinators, listed in MAINTAINERS.txt
We have discussed the responsibilities of the role and, indeed, agreed that a primary task for those joining as provisional members in this update will be to better document the processes we follow.
| Comment | File | Size | Author |
|---|
Issue fork drupal-3187240
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rachel_norfolkHey, I’m at DrupalCon Europe 2020 so adding the tag!
Comment #3
volkswagenchickGood day!
I am aware of the responsibilities and agree to be a provisional mentoring coordinator.
Thanks for the opportunity, I am excited to keep working with the team.
I am moving this issue to needs review for broader community input.
Comment #4
ultimike+1
Comment #5
xjmHooray, welcome @volkswagenchick!
Adding the references here that should have been in the summary, oops:
The next step is for @volkswagenchick to confirm on the issue that she accepts the role as described in
MAINTAINERS.txt:As well as the general maintainer role as described in the core governance.
Which I think she did above, more or less. :)
And we'll need a patch against
MAINTAINERS.txt. :)Comment #6
volkswagenchickHa! To clarify - Yes. I accept the role as described in the MAINTAINERS.txt. I read the role description on the Core Governance page and agree to the role as defined.
Thanks
Comment #7
chrisdarke commentedPatch to MAINTAINERS.txt :)
Just realised Im in idiot and missed the 'provisional members' line right below it.. updating patch in a sec.
Comment #8
chrisdarke commentedHere we go again, this time in the Provisional section.
Comment #9
volkswagenchickWondering if there should just be one patch for all 3 related issues?
Comment #10
xjmWe use separate issues because each person is offered the role individually, so we wouldn't block one person's appointment with concerns on another's. :)
The correct formatting is to add the name to the list above, with the word
(provisional)in front of it. See the PHPUnit Initiative section for an example.Probably we can group the provisional names at the end.
Thanks!
Comment #12
volkswagenchickI added a merge request (my first attempt at this process). The process is still elusive to me, so I will attach a patch in the next comment. Thanks
Comment #13
volkswagenchickI have attached a patch for review. Thanks
Comment #14
chrisdarke commentedActually we are looking to keep the name list together, there is a discussion about it in mentoring-leads. (Soon to be documented)
Name list would be in the form
There will be a separate issue to clean up the 'Provisional membership' lines which are not consistent across the file
Comment #15
chrisdarke commentedChanging to needs work to refactor the patch
Comment #17
thejimbirch commentedI updated the original Pull Request with the formatting request in #14.
Hiding the two patches, and setting to Needs Review.
Comment #19
thejimbirch commentedLooks like I needed to add a new merge request. So I did.
Comment #20
chrisdarke commentedThere is the tiny issue of the removed line that says 'Provisional Members' which is being sorted out separately in https://www.drupal.org/project/drupal/issues/3187927 (since it was inconsistent across the file) but apart from that all good, since that change will be coming across with that MR anyway... I will mark it as RTBC.
Comment #21
alexpottCommitted and pushed 051622b5b6 to 9.2.x and 1a819fbab4 to 9.1.x. Thanks!
Congratulations @volkswagenchick!