The Drupal Core Mentoring Coordinators are delighted to invite AmyJune Hineline (volkswagenchick) to the list of Provisional Mentoring Coordinators, listed in MAINTAINERS.txt

We have discussed the responsibilities of the role and, indeed, agreed that a primary task for those joining as provisional members in this update will be to better document the processes we follow.

Issue fork drupal-3187240

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rachel_norfolk created an issue. See original summary.

rachel_norfolk’s picture

Issue tags: +Europe2020

Hey, I’m at DrupalCon Europe 2020 so adding the tag!

volkswagenchick’s picture

Status: Active » Needs review

Good day!
I am aware of the responsibilities and agree to be a provisional mentoring coordinator.

Thanks for the opportunity, I am excited to keep working with the team.

I am moving this issue to needs review for broader community input.

ultimike’s picture

+1

xjm’s picture

Hooray, welcome @volkswagenchick!

Adding the references here that should have been in the summary, oops:
The next step is for @volkswagenchick to confirm on the issue that she accepts the role as described in MAINTAINERS.txt:

Mentoring coordinators recruit and coach other mentors. They work on contributor tools, documentation, and processes to make it easier for new contributors to get involved. They organize communications and logistics, and actively participate in mentoring.

As well as the general maintainer role as described in the core governance.

Which I think she did above, more or less. :)

And we'll need a patch against MAINTAINERS.txt. :)

volkswagenchick’s picture

Ha! To clarify - Yes. I accept the role as described in the MAINTAINERS.txt. I read the role description on the Core Governance page and agree to the role as defined.

Thanks

chrisdarke’s picture

StatusFileSize
new498 bytes

Patch to MAINTAINERS.txt :)

Just realised Im in idiot and missed the 'provisional members' line right below it.. updating patch in a sec.

chrisdarke’s picture

StatusFileSize
new464 bytes

Here we go again, this time in the Provisional section.

volkswagenchick’s picture

Wondering if there should just be one patch for all 3 related issues?

xjm’s picture

Status: Needs review » Needs work

We use separate issues because each person is offered the role individually, so we wouldn't block one person's appointment with concerns on another's. :)

The correct formatting is to add the name to the list above, with the word (provisional) in front of it. See the PHPUnit Initiative section for an example.

Probably we can group the provisional names at the end.

Thanks!

volkswagenchick’s picture

Status: Needs work » Needs review

I added a merge request (my first attempt at this process). The process is still elusive to me, so I will attach a patch in the next comment. Thanks

volkswagenchick’s picture

StatusFileSize
new511 bytes

I have attached a patch for review. Thanks

chrisdarke’s picture

Actually we are looking to keep the name list together, there is a discussion about it in mentoring-leads. (Soon to be documented)

Name list would be in the form

- Mauricio Dinarte 'dinarcon' https://www.drupal.org/u/dinarcon
- Lucas Hedding 'heddn' https://www.drupal.org/u/heddn
- Tara King 'sparklingrobots' https://www.drupal.org/u/sparklingrobots
- Rachel Lawson 'rachel_norfolk' https://www.drupal.org/u/rachel_norfolk
- Valery Lourie 'valthebald' https://www.drupal.org/u/valthebald
- Elli Ludwigson 'ekl1773' https://www.drupal.org/u/ekl1773
- Jess Myrbo 'xjm' https://www.drupal.org/u/xjm
- Matthew Radcliffe 'mradcliffe' https://www.drupal.org/u/mradcliffe
- (provisional) AmyJune Hineline 'volkswagenchick' https://www.drupal.org/u/volkswagenchick

Provisional membership: None at this time.

There will be a separate issue to clean up the 'Provisional membership' lines which are not consistent across the file

chrisdarke’s picture

Status: Needs review » Needs work

Changing to needs work to refactor the patch

thejimbirch made their first commit to this issue’s fork.

thejimbirch’s picture

Status: Needs work » Needs review

I updated the original Pull Request with the formatting request in #14.

Hiding the two patches, and setting to Needs Review.

thejimbirch’s picture

Looks like I needed to add a new merge request. So I did.

chrisdarke’s picture

Status: Needs review » Reviewed & tested by the community

There is the tiny issue of the removed line that says 'Provisional Members' which is being sorted out separately in https://www.drupal.org/project/drupal/issues/3187927 (since it was inconsistent across the file) but apart from that all good, since that change will be coming across with that MR anyway... I will mark it as RTBC.

alexpott’s picture

Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 051622b5b6 to 9.2.x and 1a819fbab4 to 9.1.x. Thanks!

Congratulations @volkswagenchick!

  • alexpott committed 19e3fa8 on 9.2.x
    Issue #3187240 by volkswagenchick: Add AmyJune Hineline (volkswagenchick...

  • alexpott committed 769e93e on 9.1.x
    Issue #3187240 by volkswagenchick: Add AmyJune Hineline (volkswagenchick...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.