Problem/Motivation

In #3182134: Resolve Olivero config differences after install we found that this theme wants to place the help block into the help region, but that region doesn't exist.

Proposed resolution

Put the help block into another region or create a help region.

CommentFileSizeAuthor
#7 After---patch.jpg259.25 KBranjith_kumar_k_u
#6 3182711-6.patch1.85 KBmherchel

Issue fork drupal-3182711

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

adamzimmermann’s picture

Put the help block into another region or create a help region.

Is there a preference on which approach we take here?

daniel.bosen’s picture

Is there a preference on which approach we take here?

No idea how much it matters, but Claro defines a help region, and puts the help block there.

mherchel’s picture

Status: Active » Needs review
StatusFileSize
new1.85 KB

I'm unable to get the new gitlab functionality working, so here's a patch that adds a region template so the help blocks will align with the rest of the content.

ranjith_kumar_k_u’s picture

StatusFileSize
new259.25 KB

The patch looks good,it creates help region ,new region template for help region and also updates the page.html.twig with this region.
after patch

ranjith_kumar_k_u’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Needs review

How about changing the help region to content_above instead of adding a new region only for help. Having help text beneath the breadcrumb makes sense to me and I'm not sure of the rationale for an extra region. Bartik put help into the content region for example.

adamzimmermann’s picture

How about changing the help region to content_above instead of adding a new region only for help

I assume you mean changing the help block to the content_above region?

Claro and Seven use a help region FWIW. So after there was no strong preference when this was discussed in Slack, I ended up copying this approach.

I'm not stuck on it though, as I can see how an extra region seems like overkill too.

thejimbirch made their first commit to this issue’s fork.

kumar ashutosh’s picture

The patch is working fine to display region on the block layout page.
But If when I assigned 'Help' in the 'Help' region, then nothing is happening.
There should be a listing or any menu which will redirect to the module description and related help section which will help the user to use this section.

As normally there is nothing happening on assigning the 'Help' block in the 'Help' section.

The path should be redirected to the '/admin/help/help'.

mherchel’s picture

How about changing the help region to content_above

I'm fine with either approach, but not adding a region would serve to keep the block interface less cluttered. So, that would be my first choice.

mherchel’s picture

Status: Needs review » Reviewed & tested by the community

Changes look good to me too :)

alexpott’s picture

Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 2b44c55 to 9.2.x and 9a256ce400 to 9.1.x. Thanks!

Backported 9.1.x since olivero is experimental.

  • alexpott committed 2b44c55 on 9.2.x
    Issue #3182711 by adamzimmermann, thejimbirch, mherchel,...

  • alexpott committed 9a256ce on 9.1.x
    Issue #3182711 by adamzimmermann, thejimbirch, mherchel,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.