Currently the theme_aggregator_block_item(...)-function does not know anything about the source of the feed it is presenting. This is not optimal as you many times would like to be able to show information about the blog source in a feed block listing.

This is especially true for category feed listings. In aggregator blocks showing only one feed the title of the feed is stated in the block title.

I am proposing two patches:

The first patch (aggregator.core-feed_title_to_theme.patch) makes the feed source title (named 'ftitle') sent to theme_aggregator_block_item(...) for theming purposes when a category aggregator is being rendered.

The second patch (aggregator.core-feed_title_shown_in_theme.patch) adds the feed source title (if accessible) in front of every feed in feed listings.

The first patch should definitely be included in Drupal core. The second one is a bit more debatable as it adds a difference in how category listings and single feed listings appear (in default theme), something I don't know people will object to or not*.

* They do have the option to create their own theme callback, and therefor I propose the second patch go into core, too.

Comments

Anonymous’s picture

Version: 6.4 » 7.x-dev
Status: Needs review » Needs work

Feature requests belong to the next version. Please reroll the patch for HEAD.

ztyx’s picture

Status: Needs work » Needs review
StatusFileSize
new1.28 KB
new783 bytes

Sure. Attaching patches against HEAD. The same patch naming scheme as above is used.

I've tested these patches against current HEAD and they should work well.

ztyx’s picture

Status: Needs review » Closed (fixed)

I realized this issue is actually two different issues; #324077: Source feed missing in Aggregator theme function and #324082: Present source feed in category aggregator. The first is a bug and the second a feature request.