Closed (fixed)
Project:
Drupal core
Version:
10.0.x-dev
Component:
plugin system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Jun 2020 at 17:46 UTC
Updated:
11 Jul 2022 at 20:49 UTC
Jump to comment: Most recent
Comments
Comment #2
andregp commentedIs this issue still postponed?
Comment #3
longwaveThis issue can be worked on now for removing this code in 10.0.x.
Comment #5
clayfreemanWhile the component base class wasn't explicitly marked as deprecated (which was an oversight in my opinion), it was sufficiently deprecated in a change record so I'm removing it here also.
I think this is all that's needed for follow-up. Setting to Needs Review assuming tests will pass.
Comment #6
longwaveReparenting this under the deprecation removal meta.
I guess we can close these three issues now:
#2368585: Expand unit testing for Drupal\Component\Plugin\ContextAwarePluginBase
#3153847: ContextAwarePluginTrait::validateContexts violations are missing paths
#3153852: Both component and core versions of ContextAwarePluginBase need updated deprecation documentation
Comment #7
longwaveMR looks good, I don't see any remaining code that needs to be removed after applying the patch.
Comment #8
catchI think we might want a 9.4.x/9.5.x patch here as well to fix the documentation on the component class.
Comment #9
longwaveMaybe we should do that in #3153852: Both component and core versions of ContextAwarePluginBase need updated deprecation documentation and postpone this?
Comment #10
catchLet's do that.
Unpostponed #3153852: Both component and core versions of ContextAwarePluginBase need updated deprecation documentation.
Comment #11
catchBlocked is in.
Comment #14
andypostRebased on current 10.0.x
Comment #15
spokjeCross-committing to an MR is going to be big in 2022 :)
Comment #16
andypostI'm so sorry for that, just prefer to rebase to keep history clean)
The valid status
Comment #17
spokjeSorry, didn't mean to change the status.
I hear you, but somehow when I do a rebase on a MR with deleted files I always end up with the files returning into the MR.
Just my crappy Git-skills...
Comment #18
clayfreemanThis looks good to me; RTBC.
Comment #20
catchCommitted/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!