Fix "entity" relevant typos in core [#3138800]

Problem/Motivation

Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core, and pointed by @xjm in https://www.drupal.org/project/drupal/issues/3122088#comment-13628724

+++ b/core/.cspell.json
@@ -0,0 +1,1288 @@
+      "emtity",
...
+      "entites",

Proposed resolution

@xjm: Obviously supposed to be about entities.

As title and see the change record https://www.drupal.org/node/3122084 for how to work with cspell.

Remaining tasks

Pick out all applicable words from #2972224: Add .cspell.json to automate spellchecking in Drupal core and fix them.

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#2	3138800-2.patch	2.25 KB	sja112

Comments

Comment #1

22 May 2020 at 06:15

jungle created an issue. See original summary.

Comment #2

sja112 commented 22 May 2020 at 06:52

Status:

Active

» Needs review

Status	File	Size
new	3138800-2.patch	2.25 KB

Comment #3

22 May 2020 at 07:49

Status:

Needs review

» Needs work

The last submitted patch, 2: 3138800-2.patch, failed testing. View results

Comment #4

sja112 commented 22 May 2020 at 08:01

Status:

Needs work

» Needs review

A failed test case fix seems to be out of the scope of this issue.

1) Drupal\BuildTests\Framework\Tests\BuildTestTest::testPortMany
RuntimeException: Unable to start the web server.

What should be done in this case?

Should we open another ticket for it or solve it here.

Comment #5

longwave

he/him

English

commented 22 May 2020 at 09:14

I queued a retest, we do have some random failures like that.

+++ b/core/modules/filter/src/Plugin/migrate/process/FilterID.php
@@ -204,7 +204,7 @@ protected static function getSourceFilterType($filter_id) {
-      case 'emtity_embed':
+      case 'entity_embed':

This seems to refer to D7 contrib. We should check that the contrib module didn't typo its own filter name, which would make this spelling mistake actually correct.