Problem/Motivation

Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core

  1. inheritdic over \Drupal\Tests\views\Kernel\ViewsTemplateTest::$testViews
  2. inheritdodc over \Drupal\media_library\Form\AddFormBase::trustedCallbacks()
  3. inheritoc over \Drupal\Tests\help\Functional\ExperimentalHelpTest::setUp()

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3138731-3.8_y_x.patch1.48 KBdww
#2 3138731-2.patch1.5 KBjungle

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Assigned: jungle » Unassigned
Status: Active » Needs review
StatusFileSize
new 3138731-2.patch1.5 KB
dww’s picture

dww
we/he/they
commented
Version: 9.1.x-dev » 8.8.x-dev
Category: Task » Bug report
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3138731-3.8_y_x.patch1.48 KB

Bot can't possibly fail on doc-only comment fixes like this. Confirmed #2 applies cleanly to 9.y.x branches, and that there are no more instances of those variants on "inheritdoc" anywhere in the code.

Here's a backport to 8.9.x and 8.8.x branches (git apply doesn't apply cleanly, but patch -p1 applies with fuzz).
Super trivial "reroll", so I'm going to go ahead and RTBC even though I'm uploading a patch and I've lectured @jungle not to do this. ;)

Thanks!
-Derek

  • xjm committed f9665f2 on 9.1.x 
    Issue #3138731 by jungle, dww: Fix "inheritdoc" typos in core

  • xjm committed bf1f49b on 8.9.x 
    Issue #3138731 by jungle, dww: Fix "inheritdoc" typos in core
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed #2 to 9.1.x and 9.0.x, and #3 to 8.9.x and 8.8.x. Thanks!

  • xjm committed b5bc530 on 8.8.x 
    Issue #3138731 by jungle, dww: Fix "inheritdoc" typos in core

(cherry...

  • xjm committed c897951 on 9.0.x 
    Issue #3138731 by jungle, dww: Fix "inheritdoc" typos in core

(cherry...
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented

Got committed in 3 hours! That's incredible! @dww, thanks for reviewing and your patch! :p @xjm, thanks for committing!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I think this should have been postponed on #2972224: Add .cspell.json to automate spellchecking in Drupal core. If we commit these then the wordlist needs to be updated on that patch and it'll never land. Plus we'll get to redo this issue when it lands because we have a chance of regressing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.