Closed (fixed)
Project:
Drupal core
Version:
8.9.x-dev
Component:
install system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 May 2020 at 23:19 UTC
Updated:
5 Jun 2020 at 04:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottComment #3
longwaveSo this was added back in #2352081: Prevent installation over an already installed database but it has never worked -
database_readywas always FALSE then and nothing has changed since. Tests pass so this is obviously dead code and can be removed.Comment #4
xjmConfirmed it never gets set anywhere:
I wonder what this means for the
install_verify_database_ready()task that #3120731: Incorrect "Drupal already installed" if any database settings are wrong or unsatisfactory also added a task to... maybe that's related to why that functionality went wrong in the first place?Comment #8
xjmCommitted to 9.1.x, and cherry-picked to 9.0.x and 8.9.x. I didn't cherry-pick it to 8.8.x because the other installer change wasn't.
@longwave was incorrectly not credited in the commit message (sorry) due to crossposting with myself, but I've fixed this in the issue credits themselves.
Thanks!