The word "Second" used in views sorting date plugin requires a translation context as now it is always translated in a single way (for example I see "second" translated for the meaning of "2nd", not as a time unit in views sorting area).

CommentFileSizeAuthor
#2 3134432-2.patch683 bytesqsoul

Comments

qsoul created an issue. See original summary.

qsoul’s picture

qsoul commented
Status: Active » Needs review
StatusFileSize
new 3134432-2.patch683 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3134432-2.patch, failed testing. View results

qsoul’s picture

qsoul commented
Status: Needs work » Needs review
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

LGTM.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented

Nice, good addition, but...

Shouldn't we then also do this for 'minute'? https://www.merriam-webster.com/dictionary/minute
And shouldn't we do this for all occurrences of both strings in core? (there is not a lot of them, but there are some more)

qsoul’s picture

qsoul commented

There is one small tricky thing with this issue: there are only 2 occurrences of the string "Second" in the core - the one of above and one more here - https://git.drupalcode.org/project/drupal/-/blob/8.8.x/core/lib/Drupal/C... (maybe you're right and we should add this one to the patch) - and both they have a meaning of a "time unit" but, for example, are translated incorrectly (in the meaning of ordinal number) in my language as the context is unclear. Fixing the translation itself looks the easiest way to "avoid" the issue, but it doesn't change the problem of unclear context. That is why the patch is here.

Speaking about a "minute" - looks, it occurs only once and has a "default" meaning. I have found no other cases where the word "minute" can be understood in another way by mistake, so is there a sense to add the context to it?

krzysztof domański’s picture

krzysztof domański
Location Poland
commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3046985: The word "Second" needs translation context

Yes, we need a translation context here. Unfortunately can affects existing translations. Let's discuss this in existing issues. I'm closing it as duplicate.

#3108111: Require context for one word translatables
#3046985: The word "Second" needs translation context