This was caused by #2888723: ckeditor_stylesheets cache busting: use system.css_js_query_string.
The problem occurs with code like this:
/**
* Implements hook_ckeditor_css_alter().
*/
function XXX_ckeditor_css_alter(array &$css, Editor $editor) {
$css[] = public://theme/my.css;
}
In buildContentsCssJSSetting() the code first appends the $query_string and then calls file_create_url(). For a public: path file_create_url() seems to escape the ? in the query string to become %3F.
The correct code is to make appending the query string the last stage in this function.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | ckeditor-css.3121503-7.patch | 933 bytes | adamps |
| #2 | ckeditor-css.3121503-2.patch | 784 bytes | adamps |
Comments
Comment #2
adamps commentedComment #7
adamps commentedRe-roll
Comment #10
quietone commentedCKEditor has been removed from core, CKEditor 4 is removed from Drupal Core in 10.0.0
Comment #11
adamps commentedI'm doubtful about this reassignment. I see no advantage to try to solve this issue in a deprecated ckEditor version.
If ckEditor 5 solves the problem, then this issue could be closed as fixed in Drupal 10. If not, then the issue is still open. Either way it seems to me it's a core issue. I propose that the next step is to retest with ckEditor 5 once that's stable in Drupal 10.
Comment #12
wim leersVery reasonable demand, @AdamPS!
CKEditor 4 is architected very differently from CKEditor 5.
CKEditor 4 uses an
<iframe>for the editing area. Hence you can load CSS into it. Hence the CKEditor 4 module has ahook_ckeditor_css_alter()that this issue is talking about.CKEditor 5 on the other hand does everything within the context of the current page; it does not use an
<iframe>.Consequently, there is no CKEditor 5-specific API to load styles — all you need to do is load the styles on the page that CKEditor 5 is used on, and make sure your CSS selector is prefixed with
.ck-content. See https://www.drupal.org/node/3259165 for details.Does that answer your question? 😊
Comment #13
adamps commentedGreat, thanks for the explanation then this seems to be fixed by D10 (or if you prefer outdated)
Comment #14
wim leersIn 9.5 even! 😄