drupal 9.0 core/comment module has deprecated code

Call to deprecated constant REQUEST_TIME: Deprecated in Drupal:8.3.0 and is removed from drupal:9.0.0. Use
\Drupal::time()->getRequestTime();

Attaching the patch

CommentFileSizeAuthor
#3 3113516.patch6.05 KBhimmatbhatia

Comments

himmatbhatia created an issue. See original summary.

himmatbhatia’s picture

himmatbhatia commented
Assigned: Unassigned » himmatbhatia
himmatbhatia’s picture

himmatbhatia commented
Assigned: himmatbhatia » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3113516.patch6.05 KB

I am attaching a patch for whole comment module removing REQUEST_TIME and added \Drupal::time()->getRequestTime().
Please review.

Status: Needs review » Needs work

The last submitted patch, 3: 3113516.patch, failed testing. View results

hardik_patel_12’s picture

hardik_patel_12 commented

@himmatbhatia thankyou for your patch , but i think deprecated for comment module is already covered in #2902895:[meta] replace uses of REQUEST_TIME and time() with time service, Kindly check mentioned issue.

hardik_patel_12’s picture

hardik_patel_12 commented
Parent issue: » #2902895: [meta][no patch] Replace uses of REQUEST_TIME and time() with time service
xjm’s picture

xjm
she/her
Primary language English
commented
Title: drupal 9.0 core comment module has depricated code » Comment module still uses REQUEST_TIME
Status: Needs work » Closed (duplicate)

Yep, this is a duplicate of #2902895: [meta][no patch] Replace uses of REQUEST_TIME and time() with time service. Thanks for reporting it!