Replace REQUEST_TIME in procedural code

See possibly related issues noted here:

https://www.drupal.org/project/drupal/issues/3112283#comment-13605217

Rerolling and retargeting to D10. Curious to see impact on PHPStan's baseline.

There's many places when new service got a call inside of loops, please beware it as this replacement could affect performance a lot calling \Drupal::time() instead of using constant (within request)

I bet it should be targeted to 9.4

One thread open on the MR.

Commented on the MR.

Thanks @daffie for the review.

Addressed all 3 threads.

Also opened a 9.5.x MR, where the only difference with the 10.0.x MR are the changes in core/modules/aggregator/aggregator.module, which has been removed from 10.0.x.

The code changes for both MR's look good to me.
All my points have been addressed.
For me it is RTBC.

Broken HEAD on 10.0.x currently.

Right, back in the land of the Green TestBot once more.

In #3282315: Update phpstan/phpstan and mglaman/phpstan-drupal to latest versions there was some discussion on the changes in comment and history module file (same for aggregator.module in 9.5 MR). Wether doing this

- define('HISTORY_READ_LIMIT', REQUEST_TIME - 30 * 24 * 60 * 60);
+ define('HISTORY_READ_LIMIT', \Drupal::time()->getRequestTime() - 30 * 24 * 60 * 60);

would be a good idea.
Comments: https://www.drupal.org/project/drupal/issues/3282315#comment-14542184
https://www.drupal.org/project/drupal/issues/3282315#comment-14542319

#2006632: Make HISTORY_READ_LIMIT configurable would solve those in a better way. But not sure if that last one would be a D10 blocker (for removing the deprecated usage).

Not putting back on that one, just noting down here.

I think the solutions here to call \Drupal::time() in comment.module and history.module is not correct. If you look at when module code is loaded in the Drupal kernel. It does:

    // Load all enabled modules.
    $this->container->get('module_handler')->loadAll();

    // Register stream wrappers.
    $this->container->get('stream_wrapper_manager')->register();

    // Initialize legacy request globals.
    $this->initializeRequestGlobals($request);

    // Put the request on the stack.
    $this->container->get('request_stack')->push($request);

So we're pushing the request onto the request stack after this. I think the better solution is the one in #3282315: Update phpstan/phpstan and mglaman/phpstan-drupal to latest versions - I think what we should do here is update this to the use the same solution and also link to a @todo to remove these constants. They are not constant and should be implemented differently. The issue to link to is #2006632: Make HISTORY_READ_LIMIT configurable.

@alexpott input was addressed AFAICS, back to RTBC

Committed and pushed 433f2ae0fd to 10.1.x and 55bf7eed54 to 10.0.x. Thanks!
Committed a15d0ef and pushed to 9.5.x. Thanks!