Closed (duplicate)
Project:
Drupal core
Version:
9.0.x-dev
Component:
image.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Jan 2020 at 08:08 UTC
Updated:
23 Mar 2020 at 22:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hardik_patel_12 commentedKindly review a patch.
Comment #3
hardik_patel_12 commentedComment #5
hardik_patel_12 commentedKindly review a new patch.
Comment #6
hardik_patel_12 commentedComment #8
hardik_patel_12 commentedKindly review a new patch.
Comment #9
hardik_patel_12 commentedComment #11
hardik_patel_12 commentedThe failing test isn't related to this patch.
Comment #12
hardik_patel_12 commentedComment #13
mondrakeLooks good to me.
Comment #14
andypostChecked each file in image module and replaced ones which were missed
this method is static, so no t() accessible here, also in propertyDefinitions() more t() functions used
Comment #15
andypostComment #16
martin107 commentedA) This patch still applies.
B) After searching - outside of the test directory, '*.inc' and *.module files there are no calls to t()
C) After a visual scan of the patch ... all changes are of the expected form
D) There are no unrelated changes.
E)
In other issues, of a similar form, but with a small number of changes I have recommended that we stop using t() within tests
as all tests are conducted in English unless directly testing string translation.
https://www.drupal.org/project/drupal/issues/3116080#comment-13481391
This is a large enough patch .. and the number of changes to tests is significant. Additionally progress on the meta issue has slowed.
So I am not going to recommend that here.
In short RTBC.
Comment #17
xjmThanks for working on this.
In general, issues should not be scoped by file or module; instead, they should be scoped by making the exact specific change across as much of core as possible. Reference: https://www.drupal.org/core/scope#files
In particular,
t()calls should be replaced based on whether the translation service is already available in the class, and more specifically, based on which base class it extends. (So, for example, one issue for form builders, one for controllers, one for list builders, and then splitting that up further only if the resulting patch is too large to be manageable.) We also need to decide the approach before we proceed with child issues. See #3113904: [META] Replace t() calls inside of classes for more discussion. So, closing as a duplicate of the parent issue in #3113904: [META] Replace t() calls inside of classes .Thanks!