Problem/Motivation
While reviewed patch #2473875-75: Convert uses of $_SESSION to symfony session retrieved from the request
\Drupal\user\AccountForm using pass-reset-token from request instead of query string
Proposed resolution
Consume pass-reset-token from query string
Remaining tasks
- patch and add tests for token (may need CR
- review/commit
User interface changes
no
API changes
no
Data model changes
no
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | 3150876-24.patch | 3.88 KB | andypost |
| #24 | interdiff.txt | 752 bytes | andypost |
| #18 | 3150876-18-test-only.patch | 2.95 KB | hardik_patel_12 |
Comments
Comment #2
andypostNot clear hot to add tests
Comment #3
andypostFiled #3109110: Deprecate request argument for view time cache plugin
Comment #5
andypostFix cache, probably it should use
assert()Comment #7
kunalgautam commentedComment #8
kunalgautam commentedSome change in #5 patch
Comment #9
kunalgautam commentedComment #10
andypostThank you, it counts from 0) btw maybe commiters will ask to split account form changes....
Comment #11
alexpottIn the issue summary it says:
-
pass-reset-tokenshould be checked in query string-
\Drupal\views\Plugin\views\cache\Timestores request object [3109110]Can these be broken into two separate issues. They are completely different scopes even though they were detected in the same review.
Comment #12
andypostUpdated IS and filed views part to #3109110: Deprecate request argument for view time cache plugin
Thinking about how to write test for that
Comment #13
andypostFix title and component
Comment #14
andypostComment #15
vijaycs85Here is some test coverage based on the account settings form.
Comment #17
vijaycs85Comment #18
hardik_patel_12 commentedchanging the type hint of $user variable
removing field module
About this i am not sure , but we are not using this anywhere . So can you please me to understand this get container use-case in buildAccountForm().
Kindly review a patch.
Comment #19
hardik_patel_12 commentedSorry forgot to upload interdiff.
Comment #21
vijaycs85#18good catch @Hardik_Patel_12. We might not need field related features given we are testing the entity behaviour. I will clean up.
Comment #22
hardik_patel_12 commentedCreated new issue for removing getFormObject call from UserAccountFormFieldsTest file kindly look #3154461: Removing getFormObject call from UserAccountFormFieldsTest
Comment #23
andypostOnly 1 code style fix left here, otherwise RTBC++
Comment #24
andypostFix CS
Comment #25
andypostRelated CR is https://www.drupal.org/node/2743809
Comment #26
andypostAnd the first one https://www.drupal.org/node/2150267
Explains why should use query of request
Comment #28
mxr576LGTM
Comment #29
alexpottCommitted and pushed 361ae1cb71 to 9.2.x and a6e7eeef22 to 9.1.x. Thanks!
Comment #32
andypostThank you! Now the only leftover for meta is #2484991: Add the session to the request in KernelTestBase, BrowserTestBase, and drush