A method is called incorrectly in mysql columnExists(). The resulting error message is An error occurred. Fatal error: Call to undefined method DatabaseSchema_mysql::escapeTable() in /includes/database/mysql/schema.inc on line 22

It's a minor bug but is blocking at least one other patch from being reviewed.

CommentFileSizeAuthor
#7 d7-testExists.patch1.33 KBmfb
#5 d7-testExists.patch1.33 KBmfb
#3 d7-testExists.patch1.2 KBmfb
d7.escapeTable.patch921 bytesmfb

Comments

dries’s picture

dries commented
Status: Needs review » Needs work

Good catch. Did you check the other database layers to make sure there are no copy-paste errors made? :)

I've committed this patch to CVS HEAD.

Seems like we did not have tests for this so I'm marking this 'code needs work'. Hopefully tests still follow.

mfb’s picture

mfb
they or he
commented

pgsql uses db_escape_table(). Is that the preferred way to call escapeTable()? If so I should reroll the patch. Test to follow..

mfb’s picture

mfb
they or he
commented
Status: Needs work » Needs review
StatusFileSize
new d7-testExists.patch1.2 KB

Seems like there's a need for unit tests for each function in the db layer. For now I added some tests for db_*_exists() to the regression tests.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

mfb’s picture

mfb
they or he
commented
Status: Needs work » Needs review
StatusFileSize
new d7-testExists.patch1.33 KB

here's a reroll splitting it up into two different test methods. note, maybe these should go in some unit test class rather than regression test class.

Status: Needs review » Needs work

The last submitted patch failed testing.

mfb’s picture

mfb
they or he
commented
Status: Needs work » Needs review
StatusFileSize
new d7-testExists.patch1.33 KB
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Patch looks good, test passes. RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Thanks for the follow-up, mfb. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.