Problem/Motivation

As part of #3094468: [plan] Update core JavaScript (and CSS) dependencies prior to 9.0.0-beta1 we need to update backbone.js
Version 1.40 is available, released Feb 19, 2019 *changelog*.

Proposed resolution

Update it

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 interdiff.txt885 byteslauriii
#4 3105231-4.patch159.31 KBlauriii
#2 3105231-2.patch184.97 KBbnjmnm

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review
StatusFileSize
new 3105231-2.patch184.97 KB

Copied the new version and updated core.libraries.yml - no manual testing yet. Lets see what the testbot thinks.

Status: Needs review » Needs work

The last submitted patch, 2: 3105231-2.patch, failed testing. View results

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Needs review
StatusFileSize
new 3105231-4.patch159.31 KB
new interdiff.txt885 bytes

I removed normalize related changes from the patch and fixed Drupal\KernelTests\Core\Asset\AttachedAssetsTest which was failing.

The other failed test is Drupal\Tests\field_layout\FunctionalJavascript\FieldLayoutTest which I assume is unrelated random fail.

I did some manual testing and I didn't find any regressions in Contextual Links, Toolbar, CKEditor admin, Tour, or Quick Edit.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

I see no regressions as well

  • lauriii committed 3933d16 on 9.0.x 
    Issue #3105231 by lauriii, bnjmnm, andypost: Update backbone.js to 1.4.0

  • lauriii committed 14aca80 on 8.9.x 
    Issue #3105231 by lauriii, bnjmnm, andypost: Update backbone.js to 1.4.0...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.0.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

My changes in #4 are trivial so I think I can go ahead and commit this.

Committed 3933d16 and pushed to 9.0.x and 8.9.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.