Problem/Motivation

Spun off from #3087644: Remove Drupal 8 updates up to and including 88** where we identified that trying to remove all updates in one go resulted in an enormous patch that was too difficult to review.

Proposed resolution

As per #79 from that issue, we can try and remove update tests from modules other than system.module, then remove the update hooks themselves.

Remaining tasks

Figure out what else is needed for patch to pass.

CommentFileSizeAuthor
#9 interdiff.3104977.6-9.txt12.79 KBlongwave
#9 3104977-9.patch896.44 KBlongwave
#6 interdiff.3104977.3-6.txt6.82 KBlongwave
#6 3104977-6.patch883.64 KBlongwave
#3 3104977-3.patch876.82 KBlongwave
#2 3104977.patch721.23 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
Parent issue: » #3087644: Remove Drupal 8 updates up to and including 88**
StatusFileSize
new 3104977.patch721.23 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 3104977-3.patch876.82 KB

Missed a whole bunch of fixtures. Confirmed with grep that the fixtures in core/modules/system/tests/fixtures/update are not used anywhere else.

$ git diff --name-only origin/9.0.x
core/modules/aggregator/tests/src/Functional/Update/AggregatorUpdateTest.php
core/modules/block/tests/fixtures/update/block.block.missing_schema.yml
core/modules/block/tests/fixtures/update/drupal-8.block-test-enabled-missing-schema.php
core/modules/block/tests/src/Functional/Update/BlockConditionMissingSchemaUpdateTest.php
core/modules/block/tests/src/Functional/Update/BlockContextMappingUpdateFilledTest.php
core/modules/block/tests/src/Functional/Update/BlockContextMappingUpdateTest.php
core/modules/block/tests/src/Functional/Update/BlockRemoveDisabledRegionUpdateTest.php
core/modules/block_content/tests/fixtures/update/drupal-8.views_block_content-2976334.php
core/modules/block_content/tests/fixtures/update/views.view.block_content_2976334.yml
core/modules/block_content/tests/src/Functional/Update/BlockContentReusableUpdateTest.php
core/modules/block_content/tests/src/Functional/Update/BlockContentUpdateTest.php
core/modules/comment/tests/fixtures/update/drupal-8.empty-comment-fields.3052147.php
core/modules/comment/tests/src/Functional/Update/CommentAdminViewUpdateTest.php
core/modules/comment/tests/src/Functional/Update/CommentHostnameUpdateTest.php
core/modules/comment/tests/src/Functional/Update/CommentUpdateTest.php
core/modules/contact/tests/src/Functional/Update/ContactUpdateTest.php
core/modules/content_moderation/tests/fixtures/update/drupal-8.4.0-content_moderation_installed.php
core/modules/content_moderation/tests/fixtures/update/drupal-8.5.0-content_moderation_installed.php
core/modules/content_moderation/tests/fixtures/update/drupal-8.default-cms-entity-id-2941736.php
core/modules/content_moderation/tests/fixtures/update/drupal-8.entity-form-display-dependencies-2915383.php
core/modules/content_moderation/tests/src/Functional/Update/ContentModerationUpdateTest.php
core/modules/content_moderation/tests/src/Functional/Update/DefaultContentModerationStateRevisionUpdateTest.php
core/modules/content_moderation/tests/src/Functional/Update/DefaultModerationStateUpdateTest.php
core/modules/content_moderation/tests/src/Functional/Update/EntityFormDisplayDependenciesUpdateTest.php
core/modules/content_moderation/tests/src/Functional/Update/ModeratedContentViewLatestRevisionUpdateTest.php
core/modules/content_moderation/tests/src/Functional/Update/ModerationStateViewsFieldUpdateTest.php
core/modules/content_translation/tests/src/Functional/Update/ContentTranslationUpdateTest.php
core/modules/datetime_range/tests/fixtures/update/datetime_range-filter-values.php
core/modules/datetime_range/tests/fixtures/update/field.field.node.page.field_range.yml
core/modules/datetime_range/tests/fixtures/update/field.storage.node.field_range.yml
core/modules/datetime_range/tests/fixtures/update/views.view.test_datetime_range_filter_values.yml
core/modules/datetime_range/tests/src/Functional/Update/DatetimeRangeViewUpdateTest.php
core/modules/dblog/tests/fixtures/update/dblog-2851293.php
core/modules/dblog/tests/src/Functional/Update/DblogFiltersAndFieldsUpgradeTest.php
core/modules/dblog/tests/src/Functional/Update/DblogNoLogsAvailableUpgradeTest.php
core/modules/dblog/tests/src/Functional/Update/DblogRecentLogsUsingViewsUpdateTest.php
core/modules/editor/tests/src/Functional/Update/EditorUpdateTest.php
core/modules/field/tests/fixtures/update/drupal-8.email_widget_size_setting-2578741.php
core/modules/field/tests/fixtures/update/drupal-8.remove_handler_submit_setting-2715589.php
core/modules/field/tests/fixtures/update/drupal-8.update_deleted_field_definitions-2931436.php
core/modules/field/tests/fixtures/update/drupal-8.views_entity_reference_plugins-2429191.php
core/modules/field/tests/fixtures/update/field.field.node.article.field_ref_autocreate_2412569.yml
core/modules/field/tests/fixtures/update/field.field.node.article.field_ref_views_select_2429191.yml
core/modules/field/tests/fixtures/update/field.storage.node.field_ref_autocreate_2412569.yml
core/modules/field/tests/fixtures/update/field.storage.node.field_ref_views_select_2429191.yml
core/modules/field/tests/fixtures/update/views.view.entity_reference_plugins_2429191.yml
core/modules/field/tests/src/Functional/Update/EmailWidgetSizeSettingUpdateTest.php
core/modules/field/tests/src/Functional/Update/EntityReferenceHandlerSettingUpdateTest.php
core/modules/field/tests/src/Functional/Update/FieldUpdateTest.php
core/modules/file/tests/fixtures/update/core.entity_view_display.node.article.default_2677990.yml
core/modules/file/tests/fixtures/update/drupal-8.file_formatters_update_2677990.php
core/modules/file/tests/fixtures/update/field.field.node.article.field_file_generic_2677990.yml
core/modules/file/tests/fixtures/update/field.field.node.article.field_file_table_2677990.yml
core/modules/file/tests/fixtures/update/field.storage.node.field_file_generic_2677990.yml
core/modules/file/tests/fixtures/update/field.storage.node.field_file_table_2677990.yml
core/modules/file/tests/src/Functional/Update/FileUpdateTest.php
core/modules/file/tests/src/Functional/Update/FileUsageTemporaryDeletionConfigurationUpdateTest.php
core/modules/hal/tests/fixtures/update/drupal-8.hal-hal_update_8301.php
core/modules/hal/tests/fixtures/update/drupal-8.rest-hal_update_8301.php
core/modules/hal/tests/src/Functional/Update/CreateHalSettingsForLinkDomainUpdateTest.php
core/modules/hal/tests/src/Functional/Update/MigrateLinkDomainSettingFromRestToHalUpdateTest.php
core/modules/image/tests/fixtures/update/image.image_style.test_scale_and_crop_add_anchor.yml
core/modules/image/tests/fixtures/update/test_scale_and_crop_add_anchor.php
core/modules/image/tests/src/Functional/Update/ImageUpdateTest.php
core/modules/image/tests/src/Functional/Update/ScaleAndCropAddAnchorUpdateTest.php
core/modules/jsonapi/tests/fixtures/update/drupal-8.jsonapi-jsonapi_update_8701.php
core/modules/jsonapi/tests/src/Functional/Update/ReadOnlyModeUpdateTest.php
core/modules/language/tests/src/Functional/Update/LanguageSelectWidgetUpdateTest.php
core/modules/layout_builder/tests/fixtures/update/layout-builder-enable.php
core/modules/layout_builder/tests/fixtures/update/layout-builder-extra.php
core/modules/layout_builder/tests/fixtures/update/layout-builder-field-block.php
core/modules/layout_builder/tests/fixtures/update/layout-builder-field-schema.php
core/modules/layout_builder/tests/fixtures/update/layout-builder-permissions.php
core/modules/layout_builder/tests/fixtures/update/layout-builder-tempstore.php
core/modules/layout_builder/tests/fixtures/update/layout-builder-translation.php
core/modules/layout_builder/tests/fixtures/update/layout-builder.php
core/modules/layout_builder/tests/fixtures/update/section-dependencies.php
core/modules/layout_builder/tests/src/Functional/Update/ExtraFieldUpdatePathTest.php
core/modules/layout_builder/tests/src/Functional/Update/LayoutBuilderContextMappingUpdatePathTest.php
core/modules/layout_builder/tests/src/Functional/Update/LayoutBuilderEnableUpdatePathTest.php
core/modules/layout_builder/tests/src/Functional/Update/LayoutBuilderPermissionsUpdatePathTest.php
core/modules/layout_builder/tests/src/Functional/Update/SectionDependenciesUpdatePathTest.php
core/modules/layout_builder/tests/src/Functional/Update/TempstoreKeyUpdatePathTest.php
core/modules/layout_discovery/tests/fixtures/update/drupal-8.theme-dependencies-in-module-key-2904550.php
core/modules/layout_discovery/tests/src/Functional/Update/LayoutDiscoveryDependenciesUpdateTest.php
core/modules/media/tests/fixtures/update/drupal-8.4.0-media_installed.php
core/modules/media/tests/fixtures/update/drupal-8.media-add-additional-permissions.php
core/modules/media/tests/src/Functional/Update/MediaUpdateTest.php
core/modules/media_library/tests/fixtures/update/drupal-8.7.2-media_library_installed.php
core/modules/media_library/tests/fixtures/update/drupal-8.8.x-media_library-update-views-classnames-3049943.php
core/modules/media_library/tests/fixtures/update/drupal-8.media_library-update-form-view-displays-2988433.php
core/modules/media_library/tests/fixtures/update/drupal-8.media_library-update-view-table-display-2981044.php
core/modules/media_library/tests/fixtures/update/drupal-8.media_library-update-widget-view-3020716.php
core/modules/media_library/tests/src/Functional/Update/MediaLibrarySetAdministrativePageToTableDisplayTest.php
core/modules/media_library/tests/src/Functional/Update/MediaLibraryUpdate8704Test.php
core/modules/media_library/tests/src/Functional/Update/MediaLibraryUpdateCheckboxClassesTest.php
core/modules/media_library/tests/src/Functional/Update/MediaLibraryUpdateFormAndViewDisplaysTest.php
core/modules/media_library/tests/src/Functional/Update/MediaLibraryUpdateViewLangcodeFiltersTest.php
core/modules/media_library/tests/src/Functional/Update/MediaLibraryUpdateViewPageDisplayEditDeleteLinkTest.php
core/modules/media_library/tests/src/Functional/Update/MediaLibraryUpdateViewStatusExtraFilterTest.php
core/modules/media_library/tests/src/Functional/Update/MediaLibraryUpdateViewTableDisplayTest.php
core/modules/media_library/tests/src/Functional/Update/MediaLibraryUpdateWidgetViewTest.php
core/modules/menu_link_content/tests/src/Functional/Update/MenuLinkContentUpdateTest.php
core/modules/node/tests/src/Functional/Update/NodeUpdateTest.php
core/modules/responsive_image/tests/fixtures/update/drupal-8.responsive_image-enabled.php
core/modules/responsive_image/tests/src/Functional/Update/ResponsiveImageUpdateTest.php
core/modules/rest/tests/fixtures/update/drupal-8.rest-rest_post_update_resource_granularity.php
core/modules/rest/tests/fixtures/update/drupal-8.rest-rest_update_8201.php
core/modules/rest/tests/fixtures/update/drupal-8.rest-rest_update_8203.php
core/modules/rest/tests/fixtures/update/rest-export-with-authentication-correction.php
core/modules/rest/tests/fixtures/update/rest-export-with-authentication.php
core/modules/rest/tests/fixtures/update/rest.resource.entity.comment_2721595.yml
core/modules/rest/tests/fixtures/update/rest.resource.entity.node_2721595.yml
core/modules/rest/tests/fixtures/update/rest.resource.entity.user_2721595.yml
core/modules/rest/tests/src/Functional/Update/EntityResourcePermissionsUpdateTest.php
core/modules/rest/tests/src/Functional/Update/ResourceGranularityUpdateTest.php
core/modules/rest/tests/src/Functional/Update/RestConfigurationEntitiesUpdateTest.php
core/modules/rest/tests/src/Functional/Update/RestExportAuthCorrectionUpdateTest.php
core/modules/rest/tests/src/Functional/Update/RestExportAuthUpdateTest.php
core/modules/search/tests/src/Functional/Update/BlockPageSettingTest.php
core/modules/syslog/tests/src/Functional/Update/SyslogUpdateTest.php
core/modules/system/tests/fixtures/update/drupal-8.block-context-manager-2354889.php
core/modules/system/tests/fixtures/update/drupal-8.block-test-enabled.php
core/modules/system/tests/fixtures/update/drupal-8.editor-editor_update_8001.php
core/modules/system/tests/fixtures/update/drupal-8.language-enabled.php
core/modules/system/tests/fixtures/update/drupal-8.taxonomy-parent-multilingual-3066439.php
core/modules/system/tests/fixtures/update/drupal-8.update-test-block-disabled-2513534.php
core/modules/system/tests/fixtures/update/drupal-8.views-entity-views-data-2455125.php
core/modules/system/tests/fixtures/update/drupal-8.views-entity-views-data-2846614.php
core/modules/system/tests/fixtures/update/drupal-8.views-taxonomy-parent-2543726.php
core/modules/system/tests/fixtures/update/drupal8.views-image-style-dependency-2649914.php
core/modules/taxonomy/tests/fixtures/update/core.entity_form_display.taxonomy_term.tags.default.yml
core/modules/taxonomy/tests/fixtures/update/drupal-8.taxonomy-term-publishing-status-ui-2899923.php
core/modules/taxonomy/tests/fixtures/update/drupal-8.views-taxonomy-term-publishing-status-2981887.php
core/modules/taxonomy/tests/fixtures/update/views.view.test_taxonomy_term_view_with_content_translation_status.yml
core/modules/taxonomy/tests/fixtures/update/views.view.test_taxonomy_term_view_without_content_translation_status.yml
core/modules/taxonomy/tests/src/Functional/Update/TaxonomyParentUpdateTest.php
core/modules/taxonomy/tests/src/Functional/Update/TaxonomyTermParentMultilingualTest.php
core/modules/taxonomy/tests/src/Functional/Update/TaxonomyTermUpdatePathTest.php
core/modules/taxonomy/tests/src/Functional/Update/TaxonomyVocabularyHierarchyUpdateTest.php
core/modules/text/tests/src/Functional/TextRequiredSummaryUpdateTest.php
core/modules/user/tests/fixtures/update/drupal-8.user-email-token-2587275.php
core/modules/user/tests/src/Functional/Update/UserUpdateOrderPermissionsTest.php
core/modules/views/tests/fixtures/update/argument-placeholder.php
core/modules/views/tests/fixtures/update/block.block.exposedformtest_exposed_blockpage_1.yml
core/modules/views/tests/fixtures/update/boolean-filter-values.php
core/modules/views/tests/fixtures/update/duplicate-field-handler.php
core/modules/views/tests/fixtures/update/entity-link-output-url.php
core/modules/views/tests/fixtures/update/exposed-filter-blocks.php
core/modules/views/tests/fixtures/update/filter-placeholder-text.php
core/modules/views/tests/fixtures/update/legacy-bulk-form-update.php
core/modules/views/tests/fixtures/update/limit-exposed-operators.php
core/modules/views/tests/fixtures/update/table-cache-max-age.php
core/modules/views/tests/fixtures/update/views-data-table-dependency.php
core/modules/views/tests/fixtures/update/views.view.legacy_bulk_form.yml
core/modules/views/tests/fixtures/update/views.view.node_link_update_test.yml
core/modules/views/tests/fixtures/update/views.view.placeholder_text_test.yml
core/modules/views/tests/fixtures/update/views.view.test_boolean_filter_values.yml
core/modules/views/tests/fixtures/update/views.view.test_exposed_filters.yml
core/modules/views/tests/fixtures/update/views.view.test_table_dependency_update.yml
core/modules/views/tests/fixtures/update/views.view.test_table_max_age.yml
core/modules/views/tests/src/Functional/Update/ArgumentPlaceholderUpdatePathTest.php
core/modules/views/tests/src/Functional/Update/BooleanFilterValuesUpdateTest.php
core/modules/views/tests/src/Functional/Update/BulkFormUpdateTest.php
core/modules/views/tests/src/Functional/Update/CacheabilityMetadataUpdateTest.php
core/modules/views/tests/src/Functional/Update/EntityLinkOutputUrlUpdateTest.php
core/modules/views/tests/src/Functional/Update/EntityViewsDataUpdateFilledTest.php
core/modules/views/tests/src/Functional/Update/EntityViewsDataUpdateTest.php
core/modules/views/tests/src/Functional/Update/EntityViewsMultiValueBaseFieldDataUpdateTest.php
core/modules/views/tests/src/Functional/Update/ExposedFilterBlocksUpdateTest.php
core/modules/views/tests/src/Functional/Update/FieldHandlersUpdateTest.php
core/modules/views/tests/src/Functional/Update/ImageStyleDependencyUpdateTest.php
core/modules/views/tests/src/Functional/Update/LimitOperatorsDefaultsTest.php
core/modules/views/tests/src/Functional/Update/PlaceholderTextUpdateTest.php
core/modules/views/tests/src/Functional/Update/TableDisplayCacheMaxAgeTest.php
core/modules/views/tests/src/Functional/Update/ViewCoreUpdateTest.php
core/modules/views/tests/src/Functional/Update/ViewsDataTableDependencyUpdateTest.php
core/modules/workspaces/tests/fixtures/update/drupal-8.6.0-workspaces_installed.php

The last submitted patch, 2: 3104977.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 3: 3104977-3.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3104977-6.patch883.64 KB
new interdiff.3104977.3-6.txt6.82 KB

Missed some tests somehow.

Status: Needs review » Needs work

The last submitted patch, 6: 3104977-6.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

It'd be nice if this could incorporate #3087644-92: Remove Drupal 8 updates up to and including 88**. 🙏

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3104977-9.patch896.44 KB
new interdiff.3104977.6-9.txt12.79 KB

This now includes:

As seen in test failure of #3087644-92: Remove Drupal 8 updates up to and including 88** views.view.rest_export_with_authorization_correction.yml is still used by a kernel test.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

> then remove the update hooks themselves.

Just to make sure I understand, we still do want to remove the actual update hooks here as well as adding the last removed hooks in this issue? Just removing the tests doesn't seem like such a good idea?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Ah, but of course we can't do that, because all these tests and updates are going to be interconnected and the system update tests won't pass anymore either.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Closed (outdated)

Parent issue will be used instead: #3087644: Remove Drupal 8 updates up to and including 88**