Problem/Motivation

The details.html.twig element has a variable 'required' that specifies whether it contains required fields. However, setting this variable has no effect on the visual output:

Seven

Claro

Proposed resolution

Support 'required' in details.html.twig by adding a marker to the summary title.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

details.html.twig supports 'required' by adding a marker to the summary title.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 Screen Shot 2020-04-06 at 1.56.22 PM.png158.34 KBbnjmnm
#2 Seven-details-required--core-8.8.png368.31 KBhuzooka
claro-details-required.png144.35 KBidebr
seven-details-required.png124.03 KBidebr
claro-vertical-tab-required.png157.75 KBidebr
seven-vertical-tab-required.png130.86 KBidebr

Comments

idebr created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
StatusFileSize
new Seven-details-required--core-8.8.png368.31 KB

I may be missing something, but I don't see the required marker with core 8.8.x (that is obviously not equal with the target version of this issue, but who knows...).

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: +Needs steps to reproduce
StatusFileSize
new Screen Shot 2020-04-06 at 1.56.22 PM.png158.34 KB

I used the test that was created when support for #required was added to details #2708245: Add support for required fields, but used Claro.

The required mark shows up properly.

Perhaps I'm not understanding this correctly, but between this and #2 we will need steps to reproduce in order to proceed.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

Closing as cannot reproduce.

If still a valid issue please reopen with updated issue summary.

Thanks!